[PDFBOX-1458] wasted work in PDOptionalContentProperties.setGroupEnabled()

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.7.1
• Fix Version/s: 1.8.0
• Labels: patch performance
• Assignee: Andreas Lehmkühler
• Reporter: Adrian Nistor
• Created: 28/Nov/12 18:54
• Updated: 23/Mar/13 12:56
• Resolved: 30/Nov/12 18:38

Description

The problem appears in version version 1.7.1 and in revision 1414788.
I attached a three-line patch (on.diff) that fixes it. This problem
and the attached patch are similar the previously fixed PDFBOX-1447
and its patch.

In method "PDOptionalContentProperties.setGroupEnabled", the loop over
"on" should not be executed if "enable" is "true". When "enable" is
"true", all the iterations just compute "group" and "name", and then
discard them, because the "if" condition depends on "!enable".

Similarly, in the same method
"PDOptionalContentProperties.setGroupEnabled", the loop over "off"
should not be executed if "enable" is "false". I attached a separate
patch (off.diff) for the "off" loop.