[PDFBOX-1456] wasted work in PublicKeySecurityHandler.prepareForDecryption()

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.7.1
• Fix Version/s: 1.8.0
• Labels: patch performance
• Assignee: Andreas Lehmkühler
• Reporter: Adrian Nistor
• Created: 28/Nov/12 16:07
• Updated: 23/Mar/13 12:56
• Resolved: 30/Nov/12 18:23

Description

The problem appears in version 1.7.1 and in revision 1414743. I
attached a one-line patch that fixes it. This problem and the
attached patch are similar the previously fixed PDFBOX-1447 and its
patch.

In method "PublicKeySecurityHandler.prepareForDecryption", the loop
over "recipCertificatesIt" should break immediately after
"foundRecipient" is set to "true" and "envelopedData" is set to
"ri.getContent(...)". All the iterations after "foundRecipient" is
set to "true" do not perform any useful work because the "if"
statement depends on "!foundRecipient".