Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.7.0
    • Component/s: None
    • Labels:
      None
    • Environment:
      Windows, Java 1.5

      Description

      Running ant testimage , I find several tests failing.

      ARCHIVERGB – the version of the PNG file in trunk\pdfbox\src\test\resources\input\rendering is far closer to the AI than is the one that is output. I believe the problem has to do with the Stencil Mask.

      HOTRODCMYK – same as ARCHIVERGB

      test-landscape2 – not coming out in Landscape format any more

      A few others are reported as "not identical" but they are visually identical – false-positives IMO. The above 3, however, have regressed since those image snapshots were taken ... version 1.2 IIRC.

        Activity

        Daniel Wilson created issue -
        Hide
        Andreas Lehmkühler added a comment -

        I myself introduced the issue in revision 1081149 which is part of 1.6.0.

        The problem was the calculation of the row length within the FlateFilter for predictor values >= 10. I fixed that in revision 1157529

        Show
        Andreas Lehmkühler added a comment - I myself introduced the issue in revision 1081149 which is part of 1.6.0. The problem was the calculation of the row length within the FlateFilter for predictor values >= 10. I fixed that in revision 1157529
        Hide
        Andreas Lehmkühler added a comment -

        I updated the landscape image in revision 1157533

        Show
        Andreas Lehmkühler added a comment - I updated the landscape image in revision 1157533
        Hide
        Daniel Wilson added a comment -

        Very nice correction on the FlateFilter.

        And ... yes, the code was right and the test result was wrong in the past on the test-landscape2 case. Thanks for correcting that ... sorry I saw that one wrong.

        Show
        Daniel Wilson added a comment - Very nice correction on the FlateFilter. And ... yes, the code was right and the test result was wrong in the past on the test-landscape2 case. Thanks for correcting that ... sorry I saw that one wrong.
        Hide
        Daniel Wilson added a comment -

        Andreas' fix works great!

        Show
        Daniel Wilson added a comment - Andreas' fix works great!
        Daniel Wilson made changes -
        Field Original Value New Value
        Status Open [ 1 ] Resolved [ 5 ]
        Fix Version/s 1.7.0 [ 12316940 ]
        Resolution Fixed [ 1 ]
        Daniel Wilson made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            Unassigned
            Reporter:
            Daniel Wilson
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development