[PDFBOX-1006] Unnecessary using intermediate ByteArrayInputStream to copy from given byte array to OutputStream in FlateFilter::decode

• Type: Improvement
• Status: Closed
• Priority: Trivial
• Resolution: Fixed
• Affects Version/s: 1.5.0
• Fix Version/s: 1.6.0
• Assignee: Andreas Lehmkühler
• Reporter: Sergey Vladimirov
• Created: 27/Apr/11 10:49
• Updated: 02/Jul/11 16:29
• Resolved: 09/Jun/11 08:57

Description

It is not required to use intermediate ByteArrayInputStream to copy from given byte array to OutputStream. When we have byte[], it's okay just to call write(byte[]) method of OutputStream to write all data at once.

AS IS:

// Copy data to ByteArrayInputStream for reading
bais = new ByteArrayInputStream(baos.toByteArray());
baos.close();
baos = null;

byte[] decodedData = decodePredictor(predictor, colors, bitsPerPixel, columns, bais);
bais.close();
bais = new ByteArrayInputStream(decodedData);

// write decoded data to result
while ((amountRead = bais.read(buffer)) != -1)

{ result.write(buffer, 0, amountRead); }

bais.close();
bais = null;

TO BE:

// Copy data to ByteArrayInputStream for reading
bais = new ByteArrayInputStream(baos.toByteArray());
baos.close();
baos = null;

byte[] decodedData = decodePredictor(predictor, colors, bitsPerPixel, columns, bais);
bais.close();
bais = null;

result.write(decodedData);