Uploaded image for project: 'Parquet'
  1. Parquet
  2. PARQUET-75

String decode using 'new String' is slow

Attach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Bug
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • None
    • 1.6.0
    • parquet-mr
    • None

    Description

      There are three implementations of the Binary class and only one is using the faster 'UTF8.decode' in the 'toStringUsingUTF8' method. This fixes them to all use the faster UTF8.decode.

      As noted in the comments, the 'new String' approach creates a new decoder each time, which is slower than the cached instance used by 'UTF8.decode'.

      #1. ByteArraySliceBackedBinary <-- UTF8.decode
      #2. ByteArrayBackedBinary <-- new String
      #3. ByteBufferBackedBinary <-- new String

      https://github.com/apache/incubator-parquet-mr/pull/40

      Attachments

        Issue Links

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            dweeks-netflix Daniel Weeks
            dweeks-netflix Daniel Weeks
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment