[PARQUET-422] Fix a potential bug in MessageTypeParser where we ignore and overwrite the initial value of a method parameter

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 1.8.0, 1.8.1
• Fix Version/s: 1.9.0, 1.8.2
• Component/s: parquet-mr
• Flags: Patch
• Assignee: Liwei Lin(Inactive)
• Reporter: Liwei Lin(Inactive)
• Created: 12/Jan/16 02:19
• Updated: 21/Apr/18 12:38
• Resolved: 12/Jan/16 22:46

Description

In org.apache.parquet.schema.MessageTypeParser, for addGroupType() and addPrimitiveType(), the initial value of this parameter t is ignored, and t is overwritten here.

This often indicates a mistaken belief that the write to the parameter will be conveyed back to the caller.

This is a bug found by FindBugs™.

Issue Links

• links to: PR #308