[PARQUET-390] GroupType.union(Type toMerge, boolean strict) does not honor strict parameter

• Type: Bug
• Status: Open
• Priority: Major
• Resolution: Unresolved
• Component/s: parquet-mr
• Labels: newbie parquet
• Assignee: Unassigned
• Reporter: Michael MacFadden
• Created: 04/Nov/15 14:30
• Updated: 23/Jun/24 03:27

Description

This is the code as it currently stands in master:

@Override
protected Type union(Type toMerge, boolean strict) {
  if (toMerge.isPrimitive()) {
    throw new IncompatibleSchemaModificationException("can not merge primitive type " + toMerge + " into group type " + this);
  }
  return new GroupType(toMerge.getRepetition(), getName(), mergeFields(toMerge.asGroupType()));
}

Note the call to mergeFields omits the strict parameter. I believe the code should be:

@Override
protected Type union(Type toMerge, boolean strict) {
  if (toMerge.isPrimitive()) {
    throw new IncompatibleSchemaModificationException("can not merge primitive type " + toMerge + " into group type " + this);
  }
  return new GroupType(toMerge.getRepetition(), getName(), mergeFields(toMerge.asGroupType(), strict));
}

Note the call to mergeFields includes the strict parameter.

I would work on this myself, but I'm having considerable trouble working with the codebase (see e.g. http://stackoverflow.com/questions/31229445/build-failure-apache-parquet-mr-source-mvn-install-failure). Given the (assumed) simplicity of the fix, can a seasoned Parquet contributor take this up? Cheers.