[PARQUET-250] StatisticsFilter "And"'s semantic error

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Duplicate
• Affects Version/s: 1.6.0
• Component/s: parquet-mr
• Labels: easyfix
• Assignee: Unassigned
• Reporter: Yijie Shen
• Created: 11/Apr/15 11:51
• Updated: 12/Apr/15 08:30
• Resolved: 12/Apr/15 08:30

Description

public Boolean visit(And and) {
    return and.getLeft().accept(this) && and.getRight().accept(this);
  }

visit(And and) is used to determine whether a row group "canDrop", therefore, in "And" situation, either left "canDrop" or right "canDrop" would lead the row group "canDrop", so we need a "||" here to make the choice.

Therefore, it should be:

public Boolean visit(And and) {
    return and.getLeft().accept(this) || and.getRight().accept(this);
  }

Issue Links

• duplicates: PARQUET-173 StatisticsFilter doesn't handle And properly