[PARQUET-2330] Fix convert-csv to show the correct position of the invalid record

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 1.14.0
• Component/s: parquet-cli
• Assignee: Kengo Seki
• Reporter: Kengo Seki
• Created: 03/Aug/23 11:02
• Updated: 23/Jun/24 03:33
• Resolved: 03/Aug/23 14:30

Description

Given the following input:

$ cat /tmp/input
0
1
2
3
4
5
6
7
8
9
a

running the convert-csv subcommand shows a wrong position (0) for the invalid record, as follows:

$ java -cp 'target/parquet-cli-1.14.0-SNAPSHOT.jar:target/dependency/*' org.apache.parquet.cli.Main convert-csv /tmp/input --no-header -o /tmp/output
Unknown error
java.lang.RuntimeException: Failed on record 0
	at org.apache.parquet.cli.commands.ConvertCSVCommand.run(ConvertCSVCommand.java:186)
	at org.apache.parquet.cli.Main.run(Main.java:163)
	at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:82)
	at org.apache.parquet.cli.Main.main(Main.java:193)
Caused by: org.apache.parquet.cli.util.RecordException: Field field_0: value not a ["null","long"]: 'a'
	at org.apache.parquet.cli.csv.RecordBuilder.makeValue(RecordBuilder.java:125)
	at org.apache.parquet.cli.csv.RecordBuilder.fillIndexed(RecordBuilder.java:98)
	at org.apache.parquet.cli.csv.RecordBuilder.makeRecord(RecordBuilder.java:75)
	at org.apache.parquet.cli.csv.AvroCSVReader.next(AvroCSVReader.java:84)
	at org.apache.parquet.cli.commands.ConvertCSVCommand.run(ConvertCSVCommand.java:182)
	... 3 more
Caused by: java.lang.NumberFormatException: For input string: "a"
	at java.lang.NumberFormatException.forInputString(NumberFormatException.java:65)
	at java.lang.Long.parseLong(Long.java:589)
	at java.lang.Long.valueOf(Long.java:803)
	at org.apache.parquet.cli.csv.RecordBuilder.makeValue(RecordBuilder.java:163)
	at org.apache.parquet.cli.csv.RecordBuilder.makeValue(RecordBuilder.java:178)
	at org.apache.parquet.cli.csv.RecordBuilder.makeValue(RecordBuilder.java:113)
	... 7 more