Details
-
Improvement
-
Status: Open
-
Minor
-
Resolution: Unresolved
-
None
-
None
-
None
-
None
Description
ProtoWriteSupport.java
class BinaryWriter extends FieldWriter { @Override final void writeRawValue(Object value) { ByteString byteString = (ByteString) value; Binary binary = Binary.fromConstantByteArray(byteString.toByteArray()); recordConsumer.addBinary(binary); } }
toByteArray() creates a copy of the buffer. There is already support with Parquet and Protobuf to pass instead a ByteBuffer which avoids the copy.
Attachments
Issue Links
- is blocked by
-
THRIFT-5288 Move Support for ByteBuffer into TTransport
- Closed