Uploaded image for project: 'Parquet'
  1. Parquet
  2. PARQUET-1867

[C++] Fix MetaData children object lifetime issues

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Open
    • Priority: Major
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: parquet-cpp
    • Labels:
      None

      Description

      FileMetaData::RowGroup(int i) and RowGroupMetaData::ColumnChunk returns both a unique_ptr<T> which gives the impression that the object are self-contained and safe to own without any lifetime issue.

      The reality is that the caller must hold the lifetime of the parent object. We should change the signature to a const-ref instead.

        Attachments

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              fsaintjacques Francois Saint-Jacques
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated: