[PARQUET-145] InternalParquetRecordReader.close() should not throw an exception if initialization has failed

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.6.0
• Fix Version/s: 1.6.0
• Component/s: parquet-mr
• Assignee: Wolfgang Hoschek
• Reporter: Wolfgang Hoschek
• Created: 09/Dec/14 12:14
• Updated: 07/Apr/15 20:46
• Resolved: 11/Dec/14 22:01

Description

InternalParquetRecordReader.close() currently throws a NullPointerException if initialize() didn't succeed and hence the "reader" remains null.

This NPE happens with client usage idioms like this:

AvroParquetReader reader = ...
try {
       // read some parquet data
} finally {
  if (reader != null) { reader.close(); }
}

I believe close() should read as follows:

public void close() throws IOException {
    if (reader != null) {
      reader.close();
    }
  }

Thoughts?