OpenWebBeans
  1. OpenWebBeans
  2. OWB-638

[PERF] Avoid unnecessary AbstractList$Itr instances

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: 1.1.4
    • Fix Version/s: 1.1.4
    • Component/s: Core
    • Labels:
      None
    • Environment:
      OWB trunk

      Description

      Avoid unnecessary AbstractList$Itr instances with if-check:

      if (stack.size() > 0)
      {
      ... stack.iterator()

      or with index based loop

      1. OWB-638.patch
        10 kB
        Martin Kočí

        Activity

        Hide
        Mark Struberg added a comment -

        released with OWB-1.1.4

        Show
        Mark Struberg added a comment - released with OWB-1 .1.4
        Hide
        Martin Kočí added a comment -

        Committed revision 1243672.

        Show
        Martin Kočí added a comment - Committed revision 1243672.
        Hide
        Martin Kočí added a comment -

        If there are no objections, I will commit this patch soon.

        Show
        Martin Kočí added a comment - If there are no objections, I will commit this patch soon.
        Hide
        Martin Kočí added a comment -

        patch for methods for discovered by profiler

        some public method accept List as parameter and iterates over this list with iterator, but internally OWB deliver only ArrayList - can those method use index based loop ? (example: InterceptorUtil.filterCommonInterceptorStackList)

        Show
        Martin Kočí added a comment - patch for methods for discovered by profiler some public method accept List as parameter and iterates over this list with iterator, but internally OWB deliver only ArrayList - can those method use index based loop ? (example: InterceptorUtil.filterCommonInterceptorStackList)

          People

          • Assignee:
            Martin Kočí
            Reporter:
            Martin Kočí
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development