Uploaded image for project: 'OpenWebBeans'
  1. OpenWebBeans
  2. OWB-637

[perf] ELContextStore.destroyDependents() creates unnecessary HashMap$KeyIterator instances

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Trivial
    • Resolution: Fixed
    • None
    • 1.1.4
    • None
    • None
    • OWB trunk, 1.1.4-SNAPSHOT

    Description

      org.apache.webbeans.el.ELContextStore.destroyDependents() creates many instances of java.util.HashMap$KeyIterator - it uses directly:

      Set<Bean<?>> beans = dependentObjects.keySet();
      for(Bean<?> bean : beans)

      simple if-check optimize it for situation, when user does not use named dependent beans:
      if (dependentObjects.size() > 0) {
      Set<Bean<?>> beans = dependentObjects.keySet();
      for(Bean<?> bean : beans)

      Attachments

        Activity

          People

            markoc50 Martin Kočí
            markoc50 Martin Kočí
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: