[OWB-375] Performance: OWB logging performs operations when logging disabled.

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 1.0.0-alpha-1
• Fix Version/s: 1.0.0-alpha-1
• Component/s: Core
• Assignee: Gurkan Erdogdu
• Reporter: Jacquelle Leggett
• Created: 17/May/10 17:00
• Updated: 25/May/10 05:46
• Resolved: 25/May/10 05:46

Description

Logging operations in OWB code are not guarded by Logger.isLoggable(..) or something similar and results in Strings being processed when logging is disabled.

Here's an example from AbstractInjectable:

logger.debug("Injected into bean : " + this.injectionOwnerBean.toString() + " with injection point : " + injectionPoint);

The String concatenation above will occur whether or not logging is enabled. WebBeansLogger should be modified so that the above can be changed to:
if(logger.isDebugEnabed())
logger.debug("Injected into bean : " + this.injectionOwnerBean.toString() + " with injection point : " + injectionPoint);

Generally speaking, it's best for logging statements to be guarded by an isEnabled() flag to prevent performance impacts.