OpenWebBeans
  1. OpenWebBeans
  2. OWB-318

multiple methods with same EJB @interceptors(foo.class) in same bean class get multiple interceptor instances

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: M4
    • Fix Version/s: 1.0.0
    • Labels:
      None

      Description

      One managed bean with multiple methods with the same EJB @interceptors(foo.class) get multiple interceptor instances, but we should only create 1 instance.

      See TCK method org.jboss.jsr299.tck.interceptors.tests.method.MethodLevelInterceptorTest.testInterceptorCanBeAppliedToMoreThanOneMethod().

      1. owb-318-patch.diff
        5 kB
        Rohit Dilip Kelapure

        Activity

        Hide
        Eric Covener added a comment -

        whoops, I had DEBUG logging set at JRE level for the unit test

        Show
        Eric Covener added a comment - whoops, I had DEBUG logging set at JRE level for the unit test
        Hide
        Eric Covener added a comment -

        something wrong after applying the patch, mvn -Dtest=org.apache.webbeans.newtests.interceptors.business.tests.InterceptorPerformanceTest test
        gets 25x slower, seems like it's creating too many instanes

        Show
        Eric Covener added a comment - something wrong after applying the patch, mvn -Dtest=org.apache.webbeans.newtests.interceptors.business.tests.InterceptorPerformanceTest test gets 25x slower, seems like it's creating too many instanes
        Hide
        Rohit Dilip Kelapure added a comment -

        Patch for OWB-318

        Show
        Rohit Dilip Kelapure added a comment - Patch for OWB-318
        Hide
        Eric Covener added a comment -

        reopening per Rohit

        Show
        Eric Covener added a comment - reopening per Rohit
        Hide
        Mark Struberg added a comment -

        closed all issues which got released with OpenWebBeans-1.0.0-alpha-1

        Show
        Mark Struberg added a comment - closed all issues which got released with OpenWebBeans-1.0.0-alpha-1
        Hide
        Eric Covener added a comment -

        duplicate @Interceptors in a managed bean now share an instance of the interceptor class

        Show
        Eric Covener added a comment - duplicate @Interceptors in a managed bean now share an instance of the interceptor class
        Hide
        Eric Covener added a comment -

        I'm not sure if an InterceptorDataImpl should be shared or if we should have N Impl's and one underlying interceptor class instance. Gurkan, I see you were in this neighborhood recently, DYT?

        Show
        Eric Covener added a comment - I'm not sure if an InterceptorDataImpl should be shared or if we should have N Impl's and one underlying interceptor class instance. Gurkan, I see you were in this neighborhood recently, DYT?

          People

          • Assignee:
            Eric Covener
            Reporter:
            Eric Covener
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Time Tracking

              Estimated:
              Original Estimate - 6h
              6h
              Remaining:
              Remaining Estimate - 6h
              6h
              Logged:
              Time Spent - Not Specified
              Not Specified

                Development