[OWB-1013] Race condition in Instance injection

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.2.6
• Fix Version/s: 1.5.0
• Component/s: Injection and Lookup
• Assignee: Arne Limburg
• Reporter: Tobias Stoeckmann
• Created: 26/Sep/14 08:56
• Updated: 19/Apr/15 14:53
• Resolved: 12/Apr/15 19:17

Description

OpenWebBeans is prone to flip instances of javax.enterprise.inject.Instance in multi-threaded environments.

It is possible for multiple threads to access InstanceProducer at the same time with the same creational context. If that happens, it is not verified that these threads get the correct injectionPoint out of the injectionPoints stack in the shared CreationalContextImpl.

Please see attached example source (with comments included). It'll require a debugger because it's quite tricky to get the threads into proper timing. Start main method of class de.cewe.race.Main. It constructs a simple SE container and executes two threads which will trigger the issue.

Set breakpoints at:

• de.cewe.race.CDIMain, line 46 (System.out.println)
• org.apache.webbeans.portable.InstanceProducer, line 65 (getInjectionPoint)

Wait until threads "RunnableA" and "RunnableB" reached the second breakpoint. Then let RunnableA finish. It will trigger a ClassCastException. For your own convenience, activate the second breakpoint after first one is reached. It reduces debugger noise during startup.