[ORC-897] optimization loop termination condition in readerIsCompatible method

• Type: Improvement
• Status: Closed
• Priority: Trivial
• Resolution: Fixed
• Affects Version/s: 1.8.0
• Fix Version/s: 1.8.0
• Component/s: Java
• Assignee: Yiqun Zhang
• Reporter: Yiqun Zhang
• Created: 02/Aug/21 09:02
• Updated: 03/Sep/22 22:43
• Resolved: 02/Aug/21 11:51

Description

  private static boolean sameKeys(EncryptionKey[] first,
                                  EncryptionKey[] next) {
    if (first.length != next.length) {
      return false;
    }
    for(int k = 0; k < first.length && k < next.length; ++k) {
      if (!first[k].getKeyName().equals(next[k].getKeyName()) ||
          first[k].getKeyVersion() != next[k].getKeyVersion() ||
          first[k].getAlgorithm() != next[k].getAlgorithm()) {
        return false;
      }
    }
    return true;
  }

k < next.length is not necessary
There are five similar codes.

Issue Links

• links to: GitHub Pull Request #803