[ORC-836] StringGroupFromDoubleTreeReader Use Double toString

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 1.8.0
• Fix Version/s: 1.8.0
• Assignee: David Mollitor
• Reporter: David Mollitor
• Created: 07/Jul/21 16:58
• Updated: 03/Sep/22 22:43
• Resolved: 14/Jul/21 06:18

Description

https://github.com/apache/orc/blob/fb0ed31f15d9b77b76bc5dec8721f5d9ee129879/java/core/src/java/org/apache/orc/impl/ConvertTreeReaderFactory.java#L1104-L1106

      if (!Double.isNaN(doubleValue)) {
        String string = String.valueOf(doubleValue);
        byte[] bytes = string.getBytes(StandardCharsets.UTF_8);
        assignStringGroupVectorEntry(bytesColVector, elementNum, readerType, bytes);
      }

String.valueOf simply calls Double.toString(), so just skip the jumps and call Double.toString() directly.

Also, does not need to be UTF_8. Will only ever be ASCI values.

Issue Links

• links to: GitHub Pull Request #740