[ORC-573] [C++] Fix several issues in Int128 and Decimal

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Component/s: C++
• Assignee: Gang Wu
• Reporter: Gang Wu
• Created: 02/Dec/19 04:19
• Updated: 16/Mar/23 09:29
• Resolved: 16/Mar/23 09:29

Description

Before implementing predicate pushdown for C++ ORC reader, there are some gaps and the scope of this patch is to fix them.

Int128::toDecimalString() function has used wrong parameter in substr() operations which could lead to wrong string representation of decimal values.

In addition, bloom filter and decimal column statistics store string representation of decimal values. However, we should trim trailing zeros for these string values. Otherwise, it is inconsistent with Java implementation and hard to do bloom filter checking when decimal value has a different scale in the predicate.

Lastly, we should support decimal comparison to simplify sargs implementation.

Issue Links

• links to: GitHub Pull Request #456