[ORC-429] Refactor code in TypeImpl.cc

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 1.6.0
• Component/s: C++
• Assignee: Fang Zheng
• Reporter: Fang Zheng
• Created: 31/Oct/18 22:33
• Updated: 04/Sep/19 02:00
• Resolved: 05/Nov/18 23:02

Description

Propose to make two changes to the code in TypeImpl.cc
 
1. In convertType() function: in the case of proto::Type_Kind_STRUCT, two vectors are created but never used. They shall be removed.

2. In TypeImpl::parseType() function: the function calls input.substr() to copy the substring before parsing it. This string copy can be avoided by directly parsing on the input string. Please see pull request for details.

Issue Links

• links to: GitHub Pull Request #333