[ORC-428] Use ORC_UNIQUE_PTR consistently in OrcFile, OrcHdfsFile, and Writer

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Not A Problem
• Component/s: C++
• Assignee: Unassigned
• Reporter: Fang Zheng
• Created: 30/Oct/18 22:34
• Updated: 31/Oct/18 22:22
• Resolved: 31/Oct/18 22:22

Description

In OrcFile.hh, the declarations of  readLocalFile() and other four functions return  ORC_UNIQUE_PTR:

ORC_UNIQUE_PTR<InputStream> readLocalFile(const std::string& path);

ORC_UNIQUE_PTR<InputStream> readHdfsFile(const std::string& path);

ORC_UNIQUE_PTR<Reader> createReader(ORC_UNIQUE_PTR<InputStream> stream,
const ReaderOptions& options);

ORC_UNIQUE_PTR<Writer> createWriter(const Type& type, OutputStream* stream, const WriterOptions& options);

However, these functions' definitions all return std::unique_ptr. On a system where ORC_UNIQUE_PTR is not defined as std::unique_ptr but std::auto_ptr, there is inconsistency.

 

Issue Links

• links to: GitHub Pull Request #331