Uploaded image for project: 'ORC'
  1. ORC
  2. ORC-187

Simplify BitFieldReader to only support single bits

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 1.4.0
    • Fix Version/s: 1.5.0
    • Component/s: Java, Reader
    • Labels:
      None

      Description

        /** The number of bits in one item. Non-test code always uses 1. */
        private final int bitSize;
      

      The bitField reader was originally supposed to be extensible as an Integer reader with packing - but HIVE-7219 introduced parallel unpack routines which were better.

      This makes BitFieldReader::next() the core hotspot for integer sequences.

        Attachments

        1. perf_asm.png
          189 kB
          Rajesh Balamohan
        2. perf_latest_patch.png
          144 kB
          Rajesh Balamohan
        3. perf_with_fix.png
          230 kB
          Rajesh Balamohan
        4. perf-top-bitReader.png
          22 kB
          Gopal Vijayaraghavan
        5. perf-top-bitReader-asm.png
          25 kB
          Gopal Vijayaraghavan

          Issue Links

            Activity

              People

              • Assignee:
                rajesh.balamohan Rajesh Balamohan
                Reporter:
                gopalv Gopal Vijayaraghavan
              • Votes:
                0 Vote for this issue
                Watchers:
                5 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: