[ORC-1101] Improve malformed STRUCT handling

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 1.8.0
• Fix Version/s: 1.8.0
• Component/s: C++
• Assignee: Heena Bansal
• Reporter: Dongjoon Hyun
• Created: 26/Jan/22 22:28
• Updated: 03/Sep/22 22:43
• Resolved: 27/Jan/22 18:33

Description

Why Improvement is needed

apache/orc is crashing with segmentation fault when Protobuf message of type struct is illformed with fieldnames less than subtypes. Issue  was reproducible. Refer GitHub issue for more details : https://github.com/apache/orc/issues/1021. 

What changes were done as Improvement.

The changes are made to validate the indices in the Protobuf message type tree especially for the Type_Kind_STRUCT when fieldnames are less than the subtypes_size() , so it won't crash when we convert the proto::Types to TypeImpls.

Issue Links

• links to: GitHub Pull Request #1023