[CALCITE-201] Use Pair<String, String> instead of String concatenation to reduce garba...

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Labels: github-import
• Assignee: Unassigned
• Reporter: GitHub Import
• Created: 18/Jun/14 08:34
• Updated: 18/Jun/14 08:35
• Resolved: 18/Jun/14 08:35

Description

...ge when searching in Rex expr caches

Avoid string concatenation when canonizing expressions in `RexProgramBuilder`.
At best we should avoid `Map` altogether (especially when `ProgramBuilder` is created for a known program just to optimize it), however `Pair<String, String>` key will be simpler for creation, hash code check and comparison (i.e. `String` instances will cache their hashCodes, etc)

The assumption is `expr.toString()` and `expr.getType().getFullTypeString()` are garbage-free (those methods just return already existing fields)

---------------- Imported from GitHub ----------------
Url: https://github.com/julianhyde/optiq/pull/201
Created by: vlsi
Labels:
Created at: Mon Mar 24 16:16:32 CET 2014
State: closed