Uploaded image for project: 'Calcite'
  1. Calcite
  2. CALCITE-188

Use subsumes to replace equal check in an assert check in VolcanoPlanner...

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: None
    • Labels:

      Description

      In VolcanoPlanner.changeTraitsUsingConverters(), the code uses equal to check if the converted RelNode has the required trait.

      if (rel != null) {
      assert rel.getTraitSet().contains(toTrait);
      ....
      }

      This assert check should in stead use subsumes(), since as long as the converted RelNode's trait subsumes toTrait, it would be good enough to have this converted RelNode.

      Please take a look to see if there is any issue for this fix.

      ---------------- Imported from GitHub ----------------
      Url: https://github.com/julianhyde/optiq/pull/188
      Created by: jinfengni
      Labels:
      Created at: Mon Mar 17 06:01:37 CET 2014
      State: closed

        Attachments

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              github-import GitHub Import
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: