OpenNLP
  1. OpenNLP
  2. OPENNLP-99

EventStream should extend Iterator<Event>

    Details

    • Type: New Feature New Feature
    • Status: Closed
    • Priority: Major Major
    • Resolution: Won't Fix
    • Affects Version/s: maxent-3.0.0-sourceforge
    • Fix Version/s: None
    • Component/s: Machine Learning
    • Labels:
      None

      Description

      [As requested, brought over from Sourceforge.]

      Conceptually, EventStream is just an Iterator<Event>. You would get better interoperability with other Java libraries if EventStream were declared as such. If you didn't care about backwards compatibility, I'd say just get rid of EventStream entirely and use Iterator<Event> everywhere instead.

      If you care about backwards compatibility, you could at least declare AbstractEventStream as implementing Iterator<Event> - it declares all of hasNext(), next() and remove(). I believe that shouldn't break anything, and should make all the current EventStream implementations into Iterator<Event>s.

      Why do I want this? Because, when using OpenNLP maxent from Scala, if a RealValueFileEventStream were an Iterator<Event>, I could write:

      for (event <- stream)

      { ... }

      But since it's not, I instead have to wrap it in an Iterator:

      val events = new Iterator[Event] { def hasNext = stream.hasNext def next = stream.next }
      for (event <- events) { ... }

      Or write the while loop version:

      while (stream.hasNext)

      { val event = stream.next ... }

        Activity

          People

          • Assignee:
            Joern Kottmann
            Reporter:
            Steven Bethard
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development