[OPENNLP-759] Speed up GIS training by saving Executor in the GISTrainer

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: maxent-3.0.3
• Fix Version/s: 1.7.0
• Component/s: Machine Learning
• Labels: Patch
• Assignee: Jörn Kottmann
• Reporter: Daniel Russ
• Created: 02/Mar/15 20:57
• Updated: 20/Dec/16 15:16
• Resolved: 20/Dec/16 15:16

Description

In GISTrainer.nextIteration(double) an ExecutorService is created and shutdown. I don't see a reason to create a ExecutorService for each iteration.

If you create the ExecutorService in the TrainModels(int, dataindexer, Prior, int, int) method you can save it as a field in GISTrainer or pass it as an argument to findParameters(int, double).

To test it out, I made a MyGIS and MyGISTrainer classes with the fixes. There was a 5% speedup with 100 my dataset and 100 iterations of GIS.

I would be happy to share the code with you. (I can not share my data though, sorry data-use agreements).