Uploaded image for project: 'OpenNLP'
  1. OpenNLP
  2. OPENNLP-495

DictionaryNameFinder only outputs Spans of type "default"

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: tools-1.5.3
    • Fix Version/s: tools-1.5.3
    • Component/s: Name Finder
    • Labels:
    • Environment:
      Ubuntu x64 Java 7 update 3

      Description

      The DictionaryNameFinder always creates prediction Spans of type: default. Since we want to start merging results from several name-finders it makes sense to have them all output the same tag, otherwise it is impossible to properly merge the results. I mean they will be merged but half will be with default tag and some with the other user-specified tag. They can't be evaluated like that...they have to be consistent. That is very easy to fix...All i did was to create a global, mutable, String field and I am checking whether it is null before creating the Span. If it is then the usual happens (you get the default tag), if it isn't however the Span is created with whatever tag the user has supplied. In other words, a simple setter method can be used to set what tag to use in the DictionaryNameFinder Object. Of course this only works for single-type entities but then again dictionaries tend to be single-type "repositories". I am confident that you can commit this soon...all i did was add a field, a setter method for that field and an 'if statement' before creating the Span. What can possibly go wrong?

        Attachments

        1. OPENNLP-495.patch
          0.9 kB
          Jim Piliouras
        2. OPENNLP-495-2.patch
          3 kB
          Jim Piliouras
        3. OPENNLP-495-3.patch
          3 kB
          Jim Piliouras
        4. OPENNLP-495-4.patch
          4 kB
          Jim Piliouras
        5. OPENNLP-495-5.patch
          2 kB
          Jim Piliouras
        6. OPENNLP-495-6.patch
          2 kB
          Jim Piliouras

          Activity

            People

            • Assignee:
              joern Jörn Kottmann
              Reporter:
              jim-85 Jim Piliouras
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Time Tracking

                Estimated:
                Original Estimate - 1h
                1h
                Remaining:
                Remaining Estimate - 1h
                1h
                Logged:
                Time Spent - Not Specified
                Not Specified