Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: tools-1.5.2-incubating, tools-1.5.3
    • Fix Version/s: tools-1.5.3
    • Component/s: Name Finder
    • Labels:
      None
    • Environment:
      Ubuntu 11.10 x64 Java 1.7

      Description

      The docs state that one can pass null resources to the TokenNameFinderCrossValidator but that is not the case...At the very least one has to pass an empty Map rather than null, otherwise there will be a NPE right after the first 100 iterations of training finish! Passing an empty map does the trick...Thanks William!

      At the very least you can add a null-check and create an empty map accordingly rather than letting the user do it...

        Activity

        Hide
        Jim Piliouras added a comment -

        The empty Map does the trick...Issue resolved!

        Show
        Jim Piliouras added a comment - The empty Map does the trick...Issue resolved!
        Hide
        William Colen added a comment -

        I could reproduce the error. To fix it I added some null verifications. Also included a new unit test.
        Thank you Jim for reporting. Can you please check if it is working? If yes you can close the issue.

        Show
        William Colen added a comment - I could reproduce the error. To fix it I added some null verifications. Also included a new unit test. Thank you Jim for reporting. Can you please check if it is working? If yes you can close the issue.

          People

          • Assignee:
            William Colen
            Reporter:
            Jim Piliouras
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Time Tracking

              Estimated:
              Original Estimate - 1h
              1h
              Remaining:
              Remaining Estimate - 1h
              1h
              Logged:
              Time Spent - Not Specified
              Not Specified

                Development