Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.7.1
    • Component/s: Machine Learning
    • Labels:
      None

      Description

      The support for a slack parameter inside the model should be removed from the GISModel class. Only old models which have been trained prior maxent 3.0 can have such a slack parameter or correction constant. The training code since maxent 3.0 always sets the correction constant to 1 to support backward compatibility with old models.
      Since the removal will break backward compatibility it should be aligned with the opennlp-ml redesign.

      The support to train models with a slack parameter has been completely removed in OPENNLP-165.

        Issue Links

          Activity

          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/opennlp/pull/72

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/opennlp/pull/72
          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user kottmann opened a pull request:

          https://github.com/apache/opennlp/pull/72

          OPENNLP-166: Remove or deprecate slack parameter

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/kottmann/opennlp OPENNLP-166

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/opennlp/pull/72.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #72


          commit 969b63c1e91849a4013554170967930ae0b923c9
          Author: Jörn Kottmann <joern@apache.org>
          Date: 2017-01-17T19:05:00Z

          OPENNLP-166: Remove or deprecate slack parameter


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user kottmann opened a pull request: https://github.com/apache/opennlp/pull/72 OPENNLP-166 : Remove or deprecate slack parameter You can merge this pull request into a Git repository by running: $ git pull https://github.com/kottmann/opennlp OPENNLP-166 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/opennlp/pull/72.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #72 commit 969b63c1e91849a4013554170967930ae0b923c9 Author: Jörn Kottmann <joern@apache.org> Date: 2017-01-17T19:05:00Z OPENNLP-166 : Remove or deprecate slack parameter
          Hide
          joern Joern Kottmann added a comment -

          Lets never do this change. The GIS model training is already outdated and should be replaced by the L-BFGS training. Either through our (currently broken) integration or by relying on a 3rd party solution like mallet.

          Show
          joern Joern Kottmann added a comment - Lets never do this change. The GIS model training is already outdated and should be replaced by the L-BFGS training. Either through our (currently broken) integration or by relying on a 3rd party solution like mallet.

            People

            • Assignee:
              joern Joern Kottmann
              Reporter:
              joern Joern Kottmann
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development