[OPENNLP-1321] Use LinkedHashMap for deterministic iteration order

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Done
• Fix Version/s: 1.9.4
• Assignee: Unassigned
• Reporter: Yi-Lin Wang
• Created: 19/Dec/20 22:09
• Updated: 20/Dec/20 13:45
• Resolved: 20/Dec/20 13:45

Description

The test opennlp.tools.ml.naivebayes.NaiveBayesSerializedCorrectnessTest#testPlainTextModel can fail due to a different iteration order of HashMap. The error message is as follows:

 

{{[ERROR] testPlainTextModel(opennlp.tools.ml.naivebayes.NaiveBayesSerializedCorrectnessTest) Time elapsed: 0.01 s <<< FAILURE!
org.junit.ComparisonFailure:
expected:<...ports
...}}

The fix is to change HaskMap to LinkedHashMap so that the iteration order remains stable and the failure will not occur any more. In this way, the test will be more stable.