[OPENNLP-1161] avoid using concrete tag names of XML config in GeneratorFactory.extractArtifactSerializerMappings()

• Type: Improvement
• Status: Closed
• Priority: Blocker
• Resolution: Won't Fix
• Affects Version/s: 1.8.3
• Component/s: Formats, Name Finder
• Assignee: Koji Sekiguchi
• Reporter: Koji Sekiguchi
• Created: 30/Nov/17 08:51
• Updated: 09/Mar/23 15:22
• Resolved: 05/Dec/17 02:54

Description

When working on OPENNLP-1154, I noticed this.

In GeneratorFactory.extractArtifactSerializerMappings(), it specifies concrete XML tag names:

    for (int i = 0; i < allElements.getLength(); i++) {
      if (allElements.item(i) instanceof Element) {
        Element xmlElement = (Element) allElements.item(i);

        String dictName = xmlElement.getAttribute("dict");
        if (dictName != null) {

          switch (xmlElement.getTagName()) {
            case "wordcluster":
              mapping.put(dictName, new WordClusterDictionary.WordClusterDictionarySerializer());
              break;

            case "brownclustertoken":
              mapping.put(dictName, new BrownCluster.BrownClusterSerializer());
              break;

            case "brownclustertokenclass"://, ;
              mapping.put(dictName, new BrownCluster.BrownClusterSerializer());
              break;

            case "brownclusterbigram": //, ;
              mapping.put(dictName, new BrownCluster.BrownClusterSerializer());
              break;

            case "dictionary":
              mapping.put(dictName, new DictionarySerializer());
              break;
          }
        }

        String modelName = xmlElement.getAttribute("model");
        if (modelName != null) {

          switch (xmlElement.getTagName()) {
            case "tokenpos":
              mapping.put(modelName, new POSModelSerializer());
              break;
          }
        }
      }
    }

Instead, we'd better let FeatureGeneratorFactories implement a method that returns mapping (Map<String, ArtifactSerializer<?>>) and in GeneratorFactory.extractArtifactSerializerMappings(), the framework just calls the method of FeatureGeneratorFactories, which are found in XML config.

Issue Links

• Blocked: OPENNLP-1154 change the XML format for feature generator config in NameFinder and POS Tagger
• links to: GitHub Pull Request #292