[OPENNLP-1039] PerceptronTrainer should call super.isValid() in its isValid()

• Type: Bug
• Status: Closed
• Priority: Trivial
• Resolution: Fixed
• Fix Version/s: 1.8.0
• Assignee: Koji Sekiguchi
• Reporter: Koji Sekiguchi
• Created: 21/Apr/17 09:38
• Updated: 24/Apr/17 02:01
• Resolved: 24/Apr/17 02:01

Description

The current implementation of PerceptronTrainer#isValid() is:

  public boolean isValid() {
    String algorithmName = getAlgorithm();
    return !(algorithmName != null && !(PERCEPTRON_VALUE.equals(algorithmName)));
  }

but it should call super.isValid() to check iterations and cutoff parameters because PerceptronTrainer uses them.

And if possible, I'd like to rewrite the last line (return statement) because I needed a few minutes to understand it as it has three exclamation points in one line.

Issue Links

• links to: GitHub Pull Request #177