Details

      Description

      add a new "salutation" for the User's Title field for "Prof" (e.g. Professor)

      Fix typo in English text for 452, "choose_video_settings_info_text" from "No audio/video from you PC will be published, you profile picture will be shown" to "No audio/video from your PC will be published, your profile picture will be shown"

      change the English text for 1312, "upload file explorer", from "Do directly load to whiteboard" to "Load directly to the Whiteboard".

      Fix text in English text for 1315, "recording flag", from "Do not forget start recording. One user per room always needs to start it to have the recording afterwards." To "Do not forget to 'Start recording', if you want have the meeting recorded."

      Suggest changing English text for 1462, "file explorer" from " You need moderation or the right to draw on whiteboard to upload, add, delete or load files and folders." To "You need to be a Moderator or have the 'draw on whiteboard' rights to upload, add, delete or load files and folders."

        Activity

        Hide
        George Kirkham added a comment -

        svn diff file of changes for this Improvement request

        Show
        George Kirkham added a comment - svn diff file of changes for this Improvement request
        Hide
        SebastianWagner added a comment -

        Hi George,

        seems like you have been successful in setting up your dev environment. Congrats

        The patch is committed, however two remarks:
        There was a new label 1464:
        1) It was outside the "<language></language>" Tags
        2) If you add a new label we have a common (undocumentated) rule: We add this label to all language files. You can fill up other language files the english one. However all language files should contain the same number of labels and not only a subset.
        3) Labelid 1464 is nowhere in use

        I have deleted that label and committed your patch.

        Sebastian

        Show
        SebastianWagner added a comment - Hi George, seems like you have been successful in setting up your dev environment. Congrats The patch is committed, however two remarks: There was a new label 1464: 1) It was outside the "<language></language>" Tags 2) If you add a new label we have a common (undocumentated) rule: We add this label to all language files. You can fill up other language files the english one. However all language files should contain the same number of labels and not only a subset. 3) Labelid 1464 is nowhere in use I have deleted that label and committed your patch. Sebastian
        Hide
        George Kirkham added a comment -

        I ad missed the install config script which is included within this package.

        Show
        George Kirkham added a comment - I ad missed the install config script which is included within this package.
        Hide
        George Kirkham added a comment - - edited

        EnglishTextImprovements-259-complete-language1.diff contains an entry for every language.

        Sebastian, I have added entries in all language files. Please include these changes, it would be nice to have "Prof" as a salutation for any Uni staff who are professors.

        This has been a good learning exercise. Please update me with any other practices that I should adhere to. I want to make my suggested changes as easy as possible to implement, as I really appreciate the effort everyone contributes.

        To create these changes I am using a text editor and command line svn. Over time I would like to get Eclipse working under Debian, but I have been having great issues in adding SubClipse and SpringIDE (also dependency Mylyn), using the Eclipse Software Update wizard.

        Show
        George Kirkham added a comment - - edited EnglishTextImprovements-259-complete-language1.diff contains an entry for every language. Sebastian, I have added entries in all language files. Please include these changes, it would be nice to have "Prof" as a salutation for any Uni staff who are professors. This has been a good learning exercise. Please update me with any other practices that I should adhere to. I want to make my suggested changes as easy as possible to implement, as I really appreciate the effort everyone contributes. To create these changes I am using a text editor and command line svn. Over time I would like to get Eclipse working under Debian, but I have been having great issues in adding SubClipse and SpringIDE (also dependency Mylyn), using the Eclipse Software Update wizard.
        Hide
        George Kirkham added a comment -

        Sebastian, I believe that there needs to be a code change for the new salutation to loaded by OpenMeetings ? I will attempt to check the code and see what I can find. If you are familiar with the code in this area, please check for me, and please add the appropriate code change to this request (if you have time).

        Show
        George Kirkham added a comment - Sebastian, I believe that there needs to be a code change for the new salutation to loaded by OpenMeetings ? I will attempt to check the code and see what I can find. If you are familiar with the code in this area, please check for me, and please add the appropriate code change to this request (if you have time).
        Hide
        George Kirkham added a comment -

        Sebastian, Checking through the code I was not able to find any issues, that is I did not find any code that required further changes.

        I will have admit, at this time I don't understand the below code, I assume that it is retrieving the list of salutations, but I am not sure where in the code it is getting only the "salutations" ? Is "em" a global object ?
        public List<Salutations> getUserSalutations(long language_id) {
        try {
        CriteriaBuilder cb = em.getCriteriaBuilder();
        CriteriaQuery<Salutations> cq = cb.createQuery(Salutations.class);
        Root<Salutations> from = cq.from(Salutations.class);
        CriteriaQuery<Salutations> select = cq.select(from);
        TypedQuery<Salutations> q = em.createQuery(select);
        List<Salutations> ll = q.getResultList();
        for (Salutations ti : ll)

        { ti.setLabel(fieldmanagment.getFieldByIdAndLanguage( ti.getFieldvalues_id(), language_id)); }

        return ll;

        Show
        George Kirkham added a comment - Sebastian, Checking through the code I was not able to find any issues, that is I did not find any code that required further changes. I will have admit, at this time I don't understand the below code, I assume that it is retrieving the list of salutations, but I am not sure where in the code it is getting only the "salutations" ? Is "em" a global object ? public List<Salutations> getUserSalutations(long language_id) { try { CriteriaBuilder cb = em.getCriteriaBuilder(); CriteriaQuery<Salutations> cq = cb.createQuery(Salutations.class); Root<Salutations> from = cq.from(Salutations.class); CriteriaQuery<Salutations> select = cq.select(from); TypedQuery<Salutations> q = em.createQuery(select); List<Salutations> ll = q.getResultList(); for (Salutations ti : ll) { ti.setLabel(fieldmanagment.getFieldByIdAndLanguage( ti.getFieldvalues_id(), language_id)); } return ll;
        Hide
        SebastianWagner added a comment -

        Regarding "EntityManager":
        Source code:
        @PersistenceContext
        private EntityManager em;
        => Injected by Spring. It is an EntityManager of OpenJPA that implements the interface:
        http://docs.oracle.com/javaee/5/api/javax/persistence/EntityManager.html

        Show
        SebastianWagner added a comment - Regarding "EntityManager": Source code: @PersistenceContext private EntityManager em; => Injected by Spring. It is an EntityManager of OpenJPA that implements the interface: http://docs.oracle.com/javaee/5/api/javax/persistence/EntityManager.html
        Hide
        SebastianWagner added a comment -

        I have committed your patch.
        Please make sure that you use a XML validating editor, none of your language files where XML valid.

        Show
        SebastianWagner added a comment - I have committed your patch. Please make sure that you use a XML validating editor, none of your language files where XML valid.
        Hide
        George Kirkham added a comment -

        New text has been created.

        Show
        George Kirkham added a comment - New text has been created.

          People

          • Assignee:
            SebastianWagner
            Reporter:
            George Kirkham
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development