Details

    • Type: New Feature New Feature
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None

      Description

      Chat will be more beautiful if it has an option to change font styles and font sizes

      1. web_service_restore.patch
        10 kB
        Artyom Horuzhenko
      2. snap.PNG
        21 kB
        Mukesh Reddy
      3. resources.zip
        6 kB
        Artyom Horuzhenko
      4. new_resources.zip
        5 kB
        Artyom Horuzhenko
      5. font_styles.patch
        50 kB
        Artyom Horuzhenko
      6. fixes_and_improvements.patch
        17 kB
        Artyom Horuzhenko

        Activity

        Hide
        SebastianWagner added a comment -

        I have committed and review the last changes.

        Show
        SebastianWagner added a comment - I have committed and review the last changes.
        Hide
        Alexei Fedotov added a comment -

        Artyom, do I understand correctly that I have delete all icons committed earlier?

        Show
        Alexei Fedotov added a comment - Artyom, do I understand correctly that I have delete all icons committed earlier?
        Hide
        Alexei Fedotov added a comment -

        Artyom, please, avoid \r in patches.

        Show
        Alexei Fedotov added a comment - Artyom, please, avoid \r in patches.
        Hide
        Artyom Horuzhenko added a comment -

        Unfortunately rich text input implementation is a huge task. You could use tags for changing selected text style like in some kind of forums and boards.

        Show
        Artyom Horuzhenko added a comment - Unfortunately rich text input implementation is a huge task. You could use tags for changing selected text style like in some kind of forums and boards.
        Hide
        Mukesh Reddy added a comment -

        i am getting like this is there any way to hide and apply the properties directly/normally

        Show
        Mukesh Reddy added a comment - i am getting like this is there any way to hide and apply the properties directly/normally
        Hide
        Maxim Solodovnik added a comment -

        Yes, thanks

        revision 1424509

        Show
        Maxim Solodovnik added a comment - Yes, thanks revision 1424509
        Hide
        Artyom Horuzhenko added a comment -

        I removed a new addition argument from methods in RoomWebService class. Is it enough?

        Show
        Artyom Horuzhenko added a comment - I removed a new addition argument from methods in RoomWebService class. Is it enough?
        Hide
        Maxim Solodovnik added a comment -

        I believe you need to sync OM to rev < 1424383
        create small app (for ex. using PHP) creating room and modifying its parameters
        sync OM to rev >= 1424383
        check your test application

        it should fail

        Show
        Maxim Solodovnik added a comment - I believe you need to sync OM to rev < 1424383 create small app (for ex. using PHP) creating room and modifying its parameters sync OM to rev >= 1424383 check your test application it should fail
        Hide
        Artyom Horuzhenko added a comment -

        What should I do to reproduce this bug?

        Show
        Artyom Horuzhenko added a comment - What should I do to reproduce this bug?
        Hide
        Maxim Solodovnik added a comment -

        The patch attached changes REST methods signature which will result web services break.
        Please use RoomWebService.modifyRoomParameter(String SID, Long room_id, String paramName, String paramValue) to change the value and restore REST methods signatures

        Show
        Maxim Solodovnik added a comment - The patch attached changes REST methods signature which will result web services break. Please use RoomWebService.modifyRoomParameter(String SID, Long room_id, String paramName, String paramValue) to change the value and restore REST methods signatures
        Hide
        Alexei Fedotov added a comment -

        Committed at r1424383

        Artyom, thank you for contribution

        Show
        Alexei Fedotov added a comment - Committed at r1424383 Artyom, thank you for contribution
        Hide
        Artyom Horuzhenko added a comment -

        I think that the database was not updated for some reason, I don't know why. You should try to reinstall Openmeetings.

        Show
        Artyom Horuzhenko added a comment - I think that the database was not updated for some reason, I don't know why. You should try to reinstall Openmeetings.
        Hide
        Alexei Fedotov added a comment -

        I've applied the patch and tried to send a message. I got the following exception and no message appears in the chat log. Artyom, do you know a possible reason for this?

        ERROR 12-20 13:17:33.517 ChatService.java 172466 195 org.apache.openmeetings.rem
        ote.ChatService [pool-8-thread-5] - [ChatService sendMessageWithClient]
        java.lang.NullPointerException: null
        at org.apache.openmeetings.remote.ChatService.sendMessageWithClient(Chat
        Service.java:123) ~[openmeetings-2.1.0-SNAPSHOT.jar:na]
        at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[na:1.6.
        0_31]
        at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.
        java:39) ~[na:1.6.0_31]
        at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAcces
        sorImpl.java:25) ~[na:1.6.0_31]
        at java.lang.reflect.Method.invoke(Method.java:597) ~[na:1.6.0_31]
        at org.red5.server.service.ServiceInvoker.invoke(ServiceInvoker.java:196
        ) [red5.jar:na]
        at org.red5.server.service.ServiceInvoker.invoke(ServiceInvoker.java:115
        ) [red5.jar:na]
        at org.red5.server.net.rtmp.RTMPHandler.invokeCall(RTMPHandler.java:156)
        [red5.jar:na]
        at org.red5.server.net.rtmp.RTMPHandler.onInvoke(RTMPHandler.java:397) [
        red5.jar:na]
        at org.red5.server.net.rtmp.BaseRTMPHandler.messageReceived(BaseRTMPHand
        ler.java:132) [red5.jar:na]
        at org.red5.server.net.rtmp.RTMPMinaIoHandler.messageReceived(RTMPMinaIo
        Handler.java:164) [red5.jar:na]
        at org.apache.mina.core.filterchain.DefaultIoFilterChain$TailFilter.mess
        ageReceived(DefaultIoFilterChain.java:716) [mina-core-2.0.5.jar:na]
        at org.apache.mina.core.filterchain.DefaultIoFilterChain.callNextMessage
        Received(DefaultIoFilterChain.java:434) [mina-core-2.0.5.jar:na]
        at org.apache.mina.core.filterchain.DefaultIoFilterChain.access$1200(Def
        aultIoFilterChain.java:46) [mina-core-2.0.5.jar:na]
        at org.apache.mina.core.filterchain.DefaultIoFilterChain$EntryImpl$1.mes
        sageReceived(DefaultIoFilterChain.java:796) [mina-core-2.0.5.jar:na]
        at org.apache.mina.filter.codec.ProtocolCodecFilter$ProtocolDecoderOutpu
        tImpl.flush(ProtocolCodecFilter.java:427) [mina-core-2.0.5.jar:na]
        at org.apache.mina.filter.codec.ProtocolCodecFilter.messageReceived(Prot
        ocolCodecFilter.java:245) [mina-core-2.0.5.jar:na]
        at org.apache.mina.core.filterchain.DefaultIoFilterChain.callNextMessage
        Received(DefaultIoFilterChain.java:434) [mina-core-2.0.5.jar:na]
        at org.apache.mina.core.filterchain.DefaultIoFilterChain.access$1200(Def
        aultIoFilterChain.java:46) [mina-core-2.0.5.jar:na]
        at org.apache.mina.core.filterchain.DefaultIoFilterChain$EntryImpl$1.mes
        sageReceived(DefaultIoFilterChain.java:796) [mina-core-2.0.5.jar:na]
        at org.apache.mina.core.filterchain.IoFilterEvent.fire(IoFilterEvent.jav
        a:75) [mina-core-2.0.5.jar:na]
        at org.apache.mina.core.session.IoEvent.run(IoEvent.java:63) [mina-core-
        2.0.5.jar:na]
        at org.apache.mina.filter.executor.OrderedThreadPoolExecutor$Worker.runT
        ask(OrderedThreadPoolExecutor.java:780) [mina-core-2.0.5.jar:na]
        at org.apache.mina.filter.executor.OrderedThreadPoolExecutor$Worker.runT
        asks(OrderedThreadPoolExecutor.java:772) [mina-core-2.0.5.jar:na]
        at org.apache.mina.filter.executor.OrderedThreadPoolExecutor$Worker.run(
        OrderedThreadPoolExecutor.java:714) [mina-core-2.0.5.jar:na]
        at java.lang.Thread.run(Thread.java:662) [na:1.6.0_31]

        Here is a client side log

        customInputtext onFocus : false
        customInputtext onFocus : RTL is NOT set
        onkeydown:: keyCode = 84
        onkeydown:: keyCode = 69
        onkeydown:: keyCode = 83
        onkeydown:: keyCode = 84
        onkeydown:: keyCode = 13
        send: #main_content/@_content/@inner/flexibleConferenceRoom/@_chatPanelStrict/@content/@_content1
        chatservice.sendMessageWithClient getValue : -1

        Show
        Alexei Fedotov added a comment - I've applied the patch and tried to send a message. I got the following exception and no message appears in the chat log. Artyom, do you know a possible reason for this? ERROR 12-20 13:17:33.517 ChatService.java 172466 195 org.apache.openmeetings.rem ote.ChatService [pool-8-thread-5] - [ChatService sendMessageWithClient] java.lang.NullPointerException: null at org.apache.openmeetings.remote.ChatService.sendMessageWithClient(Chat Service.java:123) ~ [openmeetings-2.1.0-SNAPSHOT.jar:na] at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[na:1.6. 0_31] at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl. java:39) ~ [na:1.6.0_31] at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAcces sorImpl.java:25) ~ [na:1.6.0_31] at java.lang.reflect.Method.invoke(Method.java:597) ~ [na:1.6.0_31] at org.red5.server.service.ServiceInvoker.invoke(ServiceInvoker.java:196 ) [red5.jar:na] at org.red5.server.service.ServiceInvoker.invoke(ServiceInvoker.java:115 ) [red5.jar:na] at org.red5.server.net.rtmp.RTMPHandler.invokeCall(RTMPHandler.java:156) [red5.jar:na] at org.red5.server.net.rtmp.RTMPHandler.onInvoke(RTMPHandler.java:397) [ red5.jar:na] at org.red5.server.net.rtmp.BaseRTMPHandler.messageReceived(BaseRTMPHand ler.java:132) [red5.jar:na] at org.red5.server.net.rtmp.RTMPMinaIoHandler.messageReceived(RTMPMinaIo Handler.java:164) [red5.jar:na] at org.apache.mina.core.filterchain.DefaultIoFilterChain$TailFilter.mess ageReceived(DefaultIoFilterChain.java:716) [mina-core-2.0.5.jar:na] at org.apache.mina.core.filterchain.DefaultIoFilterChain.callNextMessage Received(DefaultIoFilterChain.java:434) [mina-core-2.0.5.jar:na] at org.apache.mina.core.filterchain.DefaultIoFilterChain.access$1200(Def aultIoFilterChain.java:46) [mina-core-2.0.5.jar:na] at org.apache.mina.core.filterchain.DefaultIoFilterChain$EntryImpl$1.mes sageReceived(DefaultIoFilterChain.java:796) [mina-core-2.0.5.jar:na] at org.apache.mina.filter.codec.ProtocolCodecFilter$ProtocolDecoderOutpu tImpl.flush(ProtocolCodecFilter.java:427) [mina-core-2.0.5.jar:na] at org.apache.mina.filter.codec.ProtocolCodecFilter.messageReceived(Prot ocolCodecFilter.java:245) [mina-core-2.0.5.jar:na] at org.apache.mina.core.filterchain.DefaultIoFilterChain.callNextMessage Received(DefaultIoFilterChain.java:434) [mina-core-2.0.5.jar:na] at org.apache.mina.core.filterchain.DefaultIoFilterChain.access$1200(Def aultIoFilterChain.java:46) [mina-core-2.0.5.jar:na] at org.apache.mina.core.filterchain.DefaultIoFilterChain$EntryImpl$1.mes sageReceived(DefaultIoFilterChain.java:796) [mina-core-2.0.5.jar:na] at org.apache.mina.core.filterchain.IoFilterEvent.fire(IoFilterEvent.jav a:75) [mina-core-2.0.5.jar:na] at org.apache.mina.core.session.IoEvent.run(IoEvent.java:63) [mina-core- 2.0.5.jar:na] at org.apache.mina.filter.executor.OrderedThreadPoolExecutor$Worker.runT ask(OrderedThreadPoolExecutor.java:780) [mina-core-2.0.5.jar:na] at org.apache.mina.filter.executor.OrderedThreadPoolExecutor$Worker.runT asks(OrderedThreadPoolExecutor.java:772) [mina-core-2.0.5.jar:na] at org.apache.mina.filter.executor.OrderedThreadPoolExecutor$Worker.run( OrderedThreadPoolExecutor.java:714) [mina-core-2.0.5.jar:na] at java.lang.Thread.run(Thread.java:662) [na:1.6.0_31] Here is a client side log customInputtext onFocus : false customInputtext onFocus : RTL is NOT set onkeydown:: keyCode = 84 onkeydown:: keyCode = 69 onkeydown:: keyCode = 83 onkeydown:: keyCode = 84 onkeydown:: keyCode = 13 send: #main_content/@_content/@inner/flexibleConferenceRoom/@_chatPanelStrict/@content/@_content1 chatservice.sendMessageWithClient getValue : -1
        Hide
        Alexei Fedotov added a comment -

        Artyom, the patch does not apply well after Maxim's changes in r1423983. Could you please update the patch? I have committed language and resource files, so the you just have to do the smaller part which requires thinking.

        You may want to clean up the database.

        Show
        Alexei Fedotov added a comment - Artyom, the patch does not apply well after Maxim's changes in r1423983. Could you please update the patch? I have committed language and resource files, so the you just have to do the smaller part which requires thinking. You may want to clean up the database.
        Hide
        Artyom Horuzhenko added a comment -

        I have the same problem when I try to rebuild project even when I use fresh working copy from repository. Cleaning up might be helpful.

        Show
        Artyom Horuzhenko added a comment - I have the same problem when I try to rebuild project even when I use fresh working copy from repository. Cleaning up might be helpful.
        Hide
        Alexei Fedotov added a comment -

        Hello Artyom,
        thanks again for your fix, compilation passes now.

        Yet Tomcat does not start for me, and I get series of exceptions in the log. It complains about child container problem. Have you seen something like this before?

        The clean version works perfectly.

        Show
        Alexei Fedotov added a comment - Hello Artyom, thanks again for your fix, compilation passes now. Yet Tomcat does not start for me, and I get series of exceptions in the log. It complains about child container problem. Have you seen something like this before? The clean version works perfectly.
        Hide
        Artyom Horuzhenko added a comment -

        fixed

        Show
        Artyom Horuzhenko added a comment - fixed
        Hide
        Alexei Fedotov added a comment -

        Hello Artyom, I get several errors of the following type when compiling your code. Could it be that some modifications are absent in the patch?

        [javac] C:\Windows.old\om\src\org\apache\openmeetings\remote\ConferenceServi
        ce.java:540: addRoom(long,java.lang.String,long,java.lang.String,java.lang.Long,
        boolean,java.util.List<java.lang.Integer>,java.lang.Boolean,java.lang.Boolean,ja
        va.lang.Integer,java.lang.Boolean,java.util.List<java.util.Map<java.lang.String,
        java.lang.Object>>,java.lang.Boolean,java.lang.Boolean,java.lang.Boolean,java.la
        ng.String,java.lang.String,java.lang.String,java.lang.Long,java.lang.Boolean,jav
        a.lang.Boolean,java.lang.Boolean,java.lang.Boolean,java.lang.Boolean,java.lang.B
        oolean,java.lang.Boolean,java.lang.Boolean,java.lang.Boolean,java.lang.Boolean,j
        ava.lang.Boolean,boolean,boolean,boolean) in org.apache.openmeetings.data.confer
        ence.Roommanagement cannot be applied to (long,java.lang.String,long,java.lang.S
        tring,long,java.lang.Boolean,java.util.List<java.lang.Integer>,java.lang.Boolean
        ,java.lang.Boolean,java.lang.Integer,java.lang.Boolean,java.util.List<java.util.
        Map<java.lang.String,java.lang.Object>>,java.lang.Boolean,java.lang.Boolean,java
        .lang.Boolean,java.lang.Boolean,java.lang.String,java.lang.String,java.lang.Stri
        ng,long,java.lang.Boolean,java.lang.Boolean,java.lang.Boolean,java.lang.Boolean,
        java.lang.Boolean,java.lang.Boolean,java.lang.Boolean,java.lang.Boolean,java.lan
        g.Boolean,java.lang.Boolean,java.lang.Boolean,java.lang.Boolean,java.lang.Boolea
        n,java.lang.Boolean)

        Show
        Alexei Fedotov added a comment - Hello Artyom, I get several errors of the following type when compiling your code. Could it be that some modifications are absent in the patch? [javac] C:\Windows.old\om\src\org\apache\openmeetings\remote\ConferenceServi ce.java:540: addRoom(long,java.lang.String,long,java.lang.String,java.lang.Long, boolean,java.util.List<java.lang.Integer>,java.lang.Boolean,java.lang.Boolean,ja va.lang.Integer,java.lang.Boolean,java.util.List<java.util.Map<java.lang.String, java.lang.Object>>,java.lang.Boolean,java.lang.Boolean,java.lang.Boolean,java.la ng.String,java.lang.String,java.lang.String,java.lang.Long,java.lang.Boolean,jav a.lang.Boolean,java.lang.Boolean,java.lang.Boolean,java.lang.Boolean,java.lang.B oolean,java.lang.Boolean,java.lang.Boolean,java.lang.Boolean,java.lang.Boolean,j ava.lang.Boolean,boolean,boolean,boolean) in org.apache.openmeetings.data.confer ence.Roommanagement cannot be applied to (long,java.lang.String,long,java.lang.S tring,long,java.lang.Boolean,java.util.List<java.lang.Integer>,java.lang.Boolean ,java.lang.Boolean,java.lang.Integer,java.lang.Boolean,java.util.List<java.util. Map<java.lang.String,java.lang.Object>>,java.lang.Boolean,java.lang.Boolean,java .lang.Boolean,java.lang.Boolean,java.lang.String,java.lang.String,java.lang.Stri ng,long,java.lang.Boolean,java.lang.Boolean,java.lang.Boolean,java.lang.Boolean, java.lang.Boolean,java.lang.Boolean,java.lang.Boolean,java.lang.Boolean,java.lan g.Boolean,java.lang.Boolean,java.lang.Boolean,java.lang.Boolean,java.lang.Boolea n,java.lang.Boolean)
        Hide
        Artyom Horuzhenko added a comment -

        This patch allows to switch on/off html tags in room preferences and adds a new button with font styles.

        Show
        Artyom Horuzhenko added a comment - This patch allows to switch on/off html tags in room preferences and adds a new button with font styles.

          People

          • Assignee:
            Alexei Fedotov
            Reporter:
            Mukesh Reddy
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development