Openmeetings
  1. Openmeetings
  2. OPENMEETINGS-194

Command line admin: added parameter "--drop", to drop database before install

    Details

      Description

      Optional parameter "--drop" allows to drop existing database before Openmeetings install.

        Activity

        Hide
        Maxim Solodovnik added a comment -

        Closing all old 'Resolved' issues

        Show
        Maxim Solodovnik added a comment - Closing all old 'Resolved' issues
        Hide
        Maxim Solodovnik added a comment -

        Everything except for
        1) drop will not work unless any of the -db* option is specified
        2) --force
        should work as expected

        Show
        Maxim Solodovnik added a comment - Everything except for 1) drop will not work unless any of the - db * option is specified 2) --force should work as expected
        Hide
        SebastianWagner added a comment -

        There is an Exception when you do the --drop option while doing installation:

        Command:
        C:Openmeetings\dist\red5>admin -i -v -tz Europe/Berlin -email seba.wagner@gmail.com -gr
        oup webbase -user swagner --password qweqwe --db-pass admin --smtp-server smtp.webbase-design.de --db-type mysql --db-name openmeetings
        --email-auth-user i4c@webbase-design.de --system-email-address i4c@webbase-design.de --db-user root --drop

        Exception:
        DEBUG 04-28 13:56:54.760 MeetingReminderJob.java 8034 34 org.openmeetings.app.quartz.scheduler.MeetingReminderJob org.springframework.scheduling.quartz.SchedulerFactoryBean#0_Worker-2 - MeetingReminderJob.execute
        ERROR 04-28 13:56:55.608 SessionClearJob.java 8882 38 org.openmeetings.app.quartz.scheduler.SessionClearJob org.springframework.scheduling.quartz.SchedulerFactoryBean#0_Worker-1 - execute
        org.springframework.transaction.CannotCreateTransactionException: Could not open JPA EntityManager for transaction; nested exception is <openjpa-2.2.0-r422266:1244990 nonfatal general error> org.apache.openjpa.persistence.PersistenceException: Table 'sessiondata' already exists

        {stmnt 30541552 CREATE TABLE sessiondata (id BIGINT NOT NULL AUTO_INCREMENT, language_id BIGINT, organization_id BIGINT, refresh_time DATETIME, sessionXml TEXT, session_id VARCHAR(255), starttermin_time DATETIME, storePermanent BIT, user_id BIGINT, PRIMARY KEY (id)) ENGINE = myisam} [code=1050, state=42S01]
        at org.springframework.orm.jpa.JpaTransactionManager.doBegin(JpaTransactionManager.java:382) ~[org.springframework.orm-jar-3.0.6.RELEASE.jar:3.0.6.RELEASE]
        at org.springframework.transaction.support.AbstractPlatformTransactionManager.getTransaction(AbstractPlatformTransactionManager.java:371) ~[org.springframework.transaction-jar-3.0.6.RELEASE.jar:3.0.6.RELEASE]
        at org.springframework.transaction.interceptor.TransactionAspectSupport.createTransactionIfNecessary(TransactionAspectSupport.java:335) ~[org.springframework.transaction-jar-3.0.6.RELEASE.jar:3.0.6.RELEASE]
        at org.springframework.transaction.interceptor.TransactionInterceptor.invoke(TransactionInterceptor.java:105) ~[org.springframework.transaction-jar-3.0.6.RELEASE.jar:3.0.6.RELEASE]
        at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:172) ~[org.springframework.aop-jar-3.0.6.RELEASE.jar:3.0.6.RELEASE]
        at org.springframework.aop.framework.Cglib2AopProxy$DynamicAdvisedInterceptor.intercept(Cglib2AopProxy.java:621) ~[org.springframework.aop-jar-3.0.6.RELEASE.jar:3.0.6.RELEASE]
        at org.openmeetings.app.data.basic.Sessionmanagement$$EnhancerByCGLIB$$89d20ca6.clearSessionTable(<generated>) ~[cglib-jar-2.2.2.jar:na]
        at org.openmeetings.app.quartz.scheduler.SessionClearJob.doIt(SessionClearJob.java:36) ~[openmeetings-2.0.0-SNAPSHOT.jar:na]
        at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[na:1.6.0_31]
        at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source) ~[na:1.6.0_31]
        at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source) ~[na:1.6.0_31]
        at java.lang.reflect.Method.invoke(Unknown Source) ~[na:1.6.0_31]
        at org.springframework.util.MethodInvoker.invoke(MethodInvoker.java:273) [spring-core-3.0.6.RELEASE.jar:3.0.6.RELEASE]
        at org.springframework.scheduling.quartz.MethodInvokingJobDetailFactoryBean$MethodInvokingJob.executeInternal(MethodInvokingJobDetailFactoryBean.java:264) [spring-context-support-3.0.6.RELEASE.jar:3.0.6.RELEASE]
        at org.springframework.scheduling.quartz.QuartzJobBean.execute(QuartzJobBean.java:86) [spring-context-support-3.0.6.RELEASE.jar:3.0.6.RELEASE]
        at org.quartz.core.JobRunShell.run(JobRunShell.java:216) [quartz-1.8.5.jar:na]
        at org.quartz.simpl.SimpleThreadPool$WorkerThread.run(SimpleThreadPool.java:549) [quartz-1.8.5.jar:na]
        Caused by: org.apache.openjpa.persistence.PersistenceException: Table 'sessiondata' already exists {stmnt 30541552 CREATE TABLE sessiondata (id BIGINT NOT NULL AUTO_INCREMENT, language_id BIGINT, organization_id BIGINT, refresh_time DATETIME, sessionXml TEXT, session_id VARCHAR(255), starttermin_time DATETIME, storePermanent BIT, user_id BIGINT, PRIMARY KEY (id)) ENGINE = myisam}

        [code=1050, state=42S01]
        at org.apache.openjpa.jdbc.meta.MappingTool.record(MappingTool.java:559) ~[openjpa-bundle-2.2.0.jar:2.2.0]
        at org.apache.openjpa.jdbc.meta.MappingTool.record(MappingTool.java:455) ~[openjpa-bundle-2.2.0.jar:2.2.0]
        at org.apache.openjpa.jdbc.kernel.JDBCBrokerFactory.synchronizeMappings(JDBCBrokerFactory.java:160) ~[openjpa-bundle-2.2.0.jar:2.2.0]
        at org.apache.openjpa.jdbc.kernel.JDBCBrokerFactory.synchronizeMappings(JDBCBrokerFactory.java:164) ~[openjpa-bundle-2.2.0.jar:2.2.0]
        at org.apache.openjpa.jdbc.kernel.JDBCBrokerFactory.newBrokerImpl(JDBCBrokerFactory.java:122) ~[openjpa-bundle-2.2.0.jar:2.2.0]
        at org.apache.openjpa.kernel.AbstractBrokerFactory.newBroker(AbstractBrokerFactory.java:209) ~[openjpa-bundle-2.2.0.jar:2.2.0]
        at org.apache.openjpa.kernel.DelegatingBrokerFactory.newBroker(DelegatingBrokerFactory.java:156) ~[openjpa-bundle-2.2.0.jar:2.2.0]
        at org.apache.openjpa.persistence.EntityManagerFactoryImpl.createEntityManager(EntityManagerFactoryImpl.java:227) ~[openjpa-bundle-2.2.0.jar:2.2.0]
        at org.apache.openjpa.persistence.EntityManagerFactoryImpl.createEntityManager(EntityManagerFactoryImpl.java:154) ~[openjpa-bundle-2.2.0.jar:2.2.0]
        at org.apache.openjpa.persistence.EntityManagerFactoryImpl.createEntityManager(EntityManagerFactoryImpl.java:60) ~[openjpa-bundle-2.2.0.jar:2.2.0]
        at org.springframework.orm.jpa.JpaTransactionManager.createEntityManagerForTransaction(JpaTransactionManager.java:400) ~[org.springframework.orm-jar-3.0.6.RELEASE.jar:3.0.6.RELEASE]
        at org.springframework.orm.jpa.JpaTransactionManager.doBegin(JpaTransactionManager.java:321) ~[org.springframework.orm-jar-3.0.6.RELEASE.jar:3.0.6.RELEASE]
        ... 16 common frames omitted
        Caused by: org.apache.openjpa.lib.jdbc.ReportingSQLException: Table 'sessiondata' already exists

        {stmnt 30541552 CREATE TABLE sessiondata (id BIGINT NOT NULL AUTO_INCREMENT, language_id BIGINT, organization_id BIGINT, refresh_time DATETIME, sessionXml TEXT, session_id VARCHAR(255), starttermin_time DATETIME, storePermanent BIT, user_id BIGINT, PRIMARY KEY (id)) ENGINE = myisam}

        [code=1050, state=42S01]
        at org.apache.openjpa.lib.jdbc.LoggingConnectionDecorator.wrap(LoggingConnectionDecorator.java:247) ~[openjpa-bundle-2.2.0.jar:2.2.0]
        at org.apache.openjpa.lib.jdbc.LoggingConnectionDecorator.wrap(LoggingConnectionDecorator.java:231) ~[openjpa-bundle-2.2.0.jar:2.2.0]
        at org.apache.openjpa.lib.jdbc.LoggingConnectionDecorator.access$700(LoggingConnectionDecorator.java:72) ~[openjpa-bundle-2.2.0.jar:2.2.0]
        at org.apache.openjpa.lib.jdbc.LoggingConnectionDecorator$LoggingConnection$LoggingStatement.executeUpdate(LoggingConnectionDecorator.java:942) ~[openjpa-bundle-2.2.0.jar:2.2.0]
        at org.apache.openjpa.lib.jdbc.DelegatingStatement.executeUpdate(DelegatingStatement.java:114) ~[openjpa-bundle-2.2.0.jar:2.2.0]
        at org.apache.openjpa.jdbc.schema.SchemaTool.executeSQL(SchemaTool.java:1224) ~[openjpa-bundle-2.2.0.jar:2.2.0]
        at org.apache.openjpa.jdbc.schema.SchemaTool.createTable(SchemaTool.java:975) ~[openjpa-bundle-2.2.0.jar:2.2.0]
        at org.apache.openjpa.jdbc.schema.SchemaTool.add(SchemaTool.java:551) ~[openjpa-bundle-2.2.0.jar:2.2.0]
        at org.apache.openjpa.jdbc.schema.SchemaTool.add(SchemaTool.java:366) ~[openjpa-bundle-2.2.0.jar:2.2.0]
        at org.apache.openjpa.jdbc.schema.SchemaTool.run(SchemaTool.java:343) ~[openjpa-bundle-2.2.0.jar:2.2.0]
        at org.apache.openjpa.jdbc.meta.MappingTool.record(MappingTool.java:505) ~[openjpa-bundle-2.2.0.jar:2.2.0]
        ... 27 common frames omitted

        Show
        SebastianWagner added a comment - There is an Exception when you do the --drop option while doing installation: Command: C:Openmeetings\dist\red5>admin -i -v -tz Europe/Berlin -email seba.wagner@gmail.com -gr oup webbase -user swagner --password qweqwe --db-pass admin --smtp-server smtp.webbase-design.de --db-type mysql --db-name openmeetings --email-auth-user i4c@webbase-design.de --system-email-address i4c@webbase-design.de --db-user root --drop Exception: DEBUG 04-28 13:56:54.760 MeetingReminderJob.java 8034 34 org.openmeetings.app.quartz.scheduler.MeetingReminderJob org.springframework.scheduling.quartz.SchedulerFactoryBean#0_Worker-2 - MeetingReminderJob.execute ERROR 04-28 13:56:55.608 SessionClearJob.java 8882 38 org.openmeetings.app.quartz.scheduler.SessionClearJob org.springframework.scheduling.quartz.SchedulerFactoryBean#0_Worker-1 - execute org.springframework.transaction.CannotCreateTransactionException: Could not open JPA EntityManager for transaction; nested exception is <openjpa-2.2.0-r422266:1244990 nonfatal general error> org.apache.openjpa.persistence.PersistenceException: Table 'sessiondata' already exists {stmnt 30541552 CREATE TABLE sessiondata (id BIGINT NOT NULL AUTO_INCREMENT, language_id BIGINT, organization_id BIGINT, refresh_time DATETIME, sessionXml TEXT, session_id VARCHAR(255), starttermin_time DATETIME, storePermanent BIT, user_id BIGINT, PRIMARY KEY (id)) ENGINE = myisam} [code=1050, state=42S01] at org.springframework.orm.jpa.JpaTransactionManager.doBegin(JpaTransactionManager.java:382) ~ [org.springframework.orm-jar-3.0.6.RELEASE.jar:3.0.6.RELEASE] at org.springframework.transaction.support.AbstractPlatformTransactionManager.getTransaction(AbstractPlatformTransactionManager.java:371) ~ [org.springframework.transaction-jar-3.0.6.RELEASE.jar:3.0.6.RELEASE] at org.springframework.transaction.interceptor.TransactionAspectSupport.createTransactionIfNecessary(TransactionAspectSupport.java:335) ~ [org.springframework.transaction-jar-3.0.6.RELEASE.jar:3.0.6.RELEASE] at org.springframework.transaction.interceptor.TransactionInterceptor.invoke(TransactionInterceptor.java:105) ~ [org.springframework.transaction-jar-3.0.6.RELEASE.jar:3.0.6.RELEASE] at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:172) ~ [org.springframework.aop-jar-3.0.6.RELEASE.jar:3.0.6.RELEASE] at org.springframework.aop.framework.Cglib2AopProxy$DynamicAdvisedInterceptor.intercept(Cglib2AopProxy.java:621) ~ [org.springframework.aop-jar-3.0.6.RELEASE.jar:3.0.6.RELEASE] at org.openmeetings.app.data.basic.Sessionmanagement$$EnhancerByCGLIB$$89d20ca6.clearSessionTable(<generated>) ~ [cglib-jar-2.2.2.jar:na] at org.openmeetings.app.quartz.scheduler.SessionClearJob.doIt(SessionClearJob.java:36) ~ [openmeetings-2.0.0-SNAPSHOT.jar:na] at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~ [na:1.6.0_31] at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source) ~ [na:1.6.0_31] at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source) ~ [na:1.6.0_31] at java.lang.reflect.Method.invoke(Unknown Source) ~ [na:1.6.0_31] at org.springframework.util.MethodInvoker.invoke(MethodInvoker.java:273) [spring-core-3.0.6.RELEASE.jar:3.0.6.RELEASE] at org.springframework.scheduling.quartz.MethodInvokingJobDetailFactoryBean$MethodInvokingJob.executeInternal(MethodInvokingJobDetailFactoryBean.java:264) [spring-context-support-3.0.6.RELEASE.jar:3.0.6.RELEASE] at org.springframework.scheduling.quartz.QuartzJobBean.execute(QuartzJobBean.java:86) [spring-context-support-3.0.6.RELEASE.jar:3.0.6.RELEASE] at org.quartz.core.JobRunShell.run(JobRunShell.java:216) [quartz-1.8.5.jar:na] at org.quartz.simpl.SimpleThreadPool$WorkerThread.run(SimpleThreadPool.java:549) [quartz-1.8.5.jar:na] Caused by: org.apache.openjpa.persistence.PersistenceException: Table 'sessiondata' already exists {stmnt 30541552 CREATE TABLE sessiondata (id BIGINT NOT NULL AUTO_INCREMENT, language_id BIGINT, organization_id BIGINT, refresh_time DATETIME, sessionXml TEXT, session_id VARCHAR(255), starttermin_time DATETIME, storePermanent BIT, user_id BIGINT, PRIMARY KEY (id)) ENGINE = myisam} [code=1050, state=42S01] at org.apache.openjpa.jdbc.meta.MappingTool.record(MappingTool.java:559) ~ [openjpa-bundle-2.2.0.jar:2.2.0] at org.apache.openjpa.jdbc.meta.MappingTool.record(MappingTool.java:455) ~ [openjpa-bundle-2.2.0.jar:2.2.0] at org.apache.openjpa.jdbc.kernel.JDBCBrokerFactory.synchronizeMappings(JDBCBrokerFactory.java:160) ~ [openjpa-bundle-2.2.0.jar:2.2.0] at org.apache.openjpa.jdbc.kernel.JDBCBrokerFactory.synchronizeMappings(JDBCBrokerFactory.java:164) ~ [openjpa-bundle-2.2.0.jar:2.2.0] at org.apache.openjpa.jdbc.kernel.JDBCBrokerFactory.newBrokerImpl(JDBCBrokerFactory.java:122) ~ [openjpa-bundle-2.2.0.jar:2.2.0] at org.apache.openjpa.kernel.AbstractBrokerFactory.newBroker(AbstractBrokerFactory.java:209) ~ [openjpa-bundle-2.2.0.jar:2.2.0] at org.apache.openjpa.kernel.DelegatingBrokerFactory.newBroker(DelegatingBrokerFactory.java:156) ~ [openjpa-bundle-2.2.0.jar:2.2.0] at org.apache.openjpa.persistence.EntityManagerFactoryImpl.createEntityManager(EntityManagerFactoryImpl.java:227) ~ [openjpa-bundle-2.2.0.jar:2.2.0] at org.apache.openjpa.persistence.EntityManagerFactoryImpl.createEntityManager(EntityManagerFactoryImpl.java:154) ~ [openjpa-bundle-2.2.0.jar:2.2.0] at org.apache.openjpa.persistence.EntityManagerFactoryImpl.createEntityManager(EntityManagerFactoryImpl.java:60) ~ [openjpa-bundle-2.2.0.jar:2.2.0] at org.springframework.orm.jpa.JpaTransactionManager.createEntityManagerForTransaction(JpaTransactionManager.java:400) ~ [org.springframework.orm-jar-3.0.6.RELEASE.jar:3.0.6.RELEASE] at org.springframework.orm.jpa.JpaTransactionManager.doBegin(JpaTransactionManager.java:321) ~ [org.springframework.orm-jar-3.0.6.RELEASE.jar:3.0.6.RELEASE] ... 16 common frames omitted Caused by: org.apache.openjpa.lib.jdbc.ReportingSQLException: Table 'sessiondata' already exists {stmnt 30541552 CREATE TABLE sessiondata (id BIGINT NOT NULL AUTO_INCREMENT, language_id BIGINT, organization_id BIGINT, refresh_time DATETIME, sessionXml TEXT, session_id VARCHAR(255), starttermin_time DATETIME, storePermanent BIT, user_id BIGINT, PRIMARY KEY (id)) ENGINE = myisam} [code=1050, state=42S01] at org.apache.openjpa.lib.jdbc.LoggingConnectionDecorator.wrap(LoggingConnectionDecorator.java:247) ~ [openjpa-bundle-2.2.0.jar:2.2.0] at org.apache.openjpa.lib.jdbc.LoggingConnectionDecorator.wrap(LoggingConnectionDecorator.java:231) ~ [openjpa-bundle-2.2.0.jar:2.2.0] at org.apache.openjpa.lib.jdbc.LoggingConnectionDecorator.access$700(LoggingConnectionDecorator.java:72) ~ [openjpa-bundle-2.2.0.jar:2.2.0] at org.apache.openjpa.lib.jdbc.LoggingConnectionDecorator$LoggingConnection$LoggingStatement.executeUpdate(LoggingConnectionDecorator.java:942) ~ [openjpa-bundle-2.2.0.jar:2.2.0] at org.apache.openjpa.lib.jdbc.DelegatingStatement.executeUpdate(DelegatingStatement.java:114) ~ [openjpa-bundle-2.2.0.jar:2.2.0] at org.apache.openjpa.jdbc.schema.SchemaTool.executeSQL(SchemaTool.java:1224) ~ [openjpa-bundle-2.2.0.jar:2.2.0] at org.apache.openjpa.jdbc.schema.SchemaTool.createTable(SchemaTool.java:975) ~ [openjpa-bundle-2.2.0.jar:2.2.0] at org.apache.openjpa.jdbc.schema.SchemaTool.add(SchemaTool.java:551) ~ [openjpa-bundle-2.2.0.jar:2.2.0] at org.apache.openjpa.jdbc.schema.SchemaTool.add(SchemaTool.java:366) ~ [openjpa-bundle-2.2.0.jar:2.2.0] at org.apache.openjpa.jdbc.schema.SchemaTool.run(SchemaTool.java:343) ~ [openjpa-bundle-2.2.0.jar:2.2.0] at org.apache.openjpa.jdbc.meta.MappingTool.record(MappingTool.java:505) ~ [openjpa-bundle-2.2.0.jar:2.2.0] ... 27 common frames omitted
        Hide
        Maxim Solodovnik added a comment -

        imaging the following situation:
        1) client have old OM (1.9 for ex.)
        2) he/she download new OM
        3) put old DB connection props into it
        4) and run "admin -i .... --drop " to drop old DB create new one and import all the data
        In this case there is no need to specify all connection properties one more time (they are already in the file), but drop would not work

        Or even simplier
        while testing import-while-install I need to do the following:
        1) run ant jar.only
        2) run admin -i -file ... --drop
        and it is failed.

        Show
        Maxim Solodovnik added a comment - imaging the following situation: 1) client have old OM (1.9 for ex.) 2) he/she download new OM 3) put old DB connection props into it 4) and run "admin -i .... --drop " to drop old DB create new one and import all the data In this case there is no need to specify all connection properties one more time (they are already in the file), but drop would not work Or even simplier while testing import-while-install I need to do the following: 1) run ant jar.only 2) run admin -i -file ... --drop and it is failed.
        Hide
        Dmitry Zamula added a comment -

        I have fixed "2" and "3" issues. But, I dont understand the first issue - if user don't specify one of "-db*" option, then we expect, that uses Derby.

        I tested and found that the drop does not work with Derby. I'll dig in OpenJPA.

        Show
        Dmitry Zamula added a comment - I have fixed "2" and "3" issues. But, I dont understand the first issue - if user don't specify one of "- db *" option, then we expect, that uses Derby. I tested and found that the drop does not work with Derby. I'll dig in OpenJPA.
        Hide
        Maxim Solodovnik added a comment -

        The fix need to be improved.

        Current issues are:
        1) drop will not work unless any of the -db* option is specified
        2) drop will drop not all tables (tables count is reduced since 1.9)
        3) drop will throw an exception if table name is changed/table is added

        Show
        Maxim Solodovnik added a comment - The fix need to be improved. Current issues are: 1) drop will not work unless any of the - db * option is specified 2) drop will drop not all tables (tables count is reduced since 1.9) 3) drop will throw an exception if table name is changed/table is added
        Hide
        Maxim Solodovnik added a comment -

        Commited: revision 1329184.

        Thanks
        please provide patch using latest available sources in the future

        Show
        Maxim Solodovnik added a comment - Commited: revision 1329184. Thanks please provide patch using latest available sources in the future
        Hide
        Dmitry Zamula added a comment -

        The third version of the patch.

        Show
        Dmitry Zamula added a comment - The third version of the patch.
        Hide
        Dmitry Zamula added a comment -

        Thanks for the correction. For "boolean force = cmdl.hasOption ("force")? true: false;" I felt ashamed =).

        Show
        Dmitry Zamula added a comment - Thanks for the correction. For "boolean force = cmdl.hasOption ("force")? true: false;" I felt ashamed =).
        Hide
        Maxim Solodovnik added a comment -

        Thanks
        another portion of criticism :
        1) boolean force = cmdl.hasOption("force") ? true : false; is equivalent to boolean force = cmdl.hasOption("force");
        2) connectionProperties.setDriverName("org.apache.derby.jdbc.ClientDriver"); – IMHO driver name should not be hardcoded (for example there is 2 drivers for Oracle and user might set 1 of them manually)

        this is my last correction, i promise

        Show
        Maxim Solodovnik added a comment - Thanks another portion of criticism : 1) boolean force = cmdl.hasOption("force") ? true : false; is equivalent to boolean force = cmdl.hasOption("force"); 2) connectionProperties.setDriverName("org.apache.derby.jdbc.ClientDriver"); – IMHO driver name should not be hardcoded (for example there is 2 drivers for Oracle and user might set 1 of them manually) this is my last correction, i promise
        Hide
        Dmitry Zamula added a comment -

        Modified version of the patch

        Show
        Dmitry Zamula added a comment - Modified version of the patch
        Hide
        Maxim Solodovnik added a comment -

        Hello Dmitry,

        I like the patch.
        There only 1 thing I would like to change: I feel default* properties need to be removed from ConnectionProperties class.

        These properties will work wrong in following case:
        1) user download OM
        2) unarchive it
        3) modifies <DB>_persistence.xml file
        4) run install with --db-type <DB> key

        I feel I will be better to to remove default* properties and set "real" properties with the data from *persistence.xml file

        What do you think on this?

        Show
        Maxim Solodovnik added a comment - Hello Dmitry, I like the patch. There only 1 thing I would like to change: I feel default* properties need to be removed from ConnectionProperties class. These properties will work wrong in following case: 1) user download OM 2) unarchive it 3) modifies <DB>_persistence.xml file 4) run install with --db-type <DB> key I feel I will be better to to remove default* properties and set "real" properties with the data from *persistence.xml file What do you think on this?
        Hide
        Dmitry Zamula added a comment -

        Patch

        Show
        Dmitry Zamula added a comment - Patch

          People

          • Assignee:
            Maxim Solodovnik
            Reporter:
            Dmitry Zamula
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development