[OPENJPA-826] moving some code outside of lock boundaries, that don't need to be locked

• Type: Improvement
• Status: Open
• Priority: Major
• Resolution: Unresolved
• Affects Version/s: 2.0.0-M2
• Component/s: slice
• Assignee: Unassigned
• Reporter: Fernando Padilla
• Created: 13/Dec/08 01:10
• Updated: 20/Dec/08 07:02

Description

I am reviewing code because of slices concurrency/multithreaded issues, and I see that some code in QueryImpl was too aggressive in their locks. So I reviewed QueryImpl and BrokerImpl...

Mainly: assertMethods do not need to be within the lock.

Then I found a few methods that were doing precondition/shortcut checking, but all within locks, so that seemed like a waste:

1) QueryImpl.setCandiateExtent; checks to see if value setting is same as current value

2) these places check to see if it needs to calculate the value of not:
QueryImpl.isUnique, QueryImpl.setCandiateExtent, QueryImpl.getCandidateType, QueryImpl.getResultType, QueryImpl.getParameterDeclaration

Issue Links

• is related to: OPENJPA-825 slices: hangs with multithreaded true