OpenJPA
  1. OpenJPA
  2. OPENJPA-651

Disable dangerous "fallback enhancement", make openjpa.RuntimeUnenhancedClasses=unsupported the default

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.0.3, 1.1.0, 1.2.1, 2.0.0-M1, 2.0.0-M2
    • Fix Version/s: 2.0.0-M3
    • Component/s: jpa, kernel, UnenhancedClasses
    • Labels:
      None

      Description

      As discussed on the email thread 'Disable dangerous "fallback enhancement" how?' on users@openjpa.apache.org (e.g. on http://markmail.org/message/5e2yfcp3w3vhmrob?q=Disable+dangerous+%22fallback+enhancement%22+how%3F+list:org%2Eapache%2Eopenjpa%2Eusers), I hereby suggest that by default, OpenJPA behaves as if openjpa.RuntimeUnenhancedClasses=unsupported was explicitly configured.

      (Copy/paste) The fact that https://issues.apache.org/jira/browse/OPENJPA-293 is still an Open New Feature, with five open sub-tasks (so technically this development was never finished, yet it's automatically activated and shows up in the official doc) and in e.g. https://issues.apache.org/jira/browse/OPENJPA-444 (and may be others?) there are bug reports which are probably only due to this, may support my point of view?

      Craig (Craig.Russell@...) appears to support this proposed Improvement (judging from his email lundi, 23. juin 2008 21:33 in same thread).

      I'd love to see this in 1.1.1. May be due to backward compatibility you jugde it would be safer to put this in 1.2.0 only? - Or is too late and impossible to change this default now? Hope not!

      PS: Workaround for 1.1.0 is openjpa.RuntimeUnenhancedClasses=unsupported (undocumented, see https://issues.apache.org/jira/browse/OPENJPA-650).

        Activity

        Hide
        Michael Dick added a comment -

        I've changed the default to unsupported for trunk (2.0.0). I'm less sanguine about changing it in 1.3.x but I could be persuaded to make the change there too.

        For 1.2.x and older I think we need to keep the current setting - to avoid breaking existing apps.

        Show
        Michael Dick added a comment - I've changed the default to unsupported for trunk (2.0.0). I'm less sanguine about changing it in 1.3.x but I could be persuaded to make the change there too. For 1.2.x and older I think we need to keep the current setting - to avoid breaking existing apps.
        Hide
        Michael Dick added a comment -

        Pursuant to the vote [1] on the dev mailing list I'm planning on turning subclassing off by default in trunk. 1.3.x may follow shortly.

        [1] http://n2.nabble.com/-VOTE--Turn-off-enhancement-by-subclassing-as-the-default-tp1616140p1616140.html

        Show
        Michael Dick added a comment - Pursuant to the vote [1] on the dev mailing list I'm planning on turning subclassing off by default in trunk. 1.3.x may follow shortly. [1] http://n2.nabble.com/-VOTE--Turn-off-enhancement-by-subclassing-as-the-default-tp1616140p1616140.html
        Hide
        Craig L Russell added a comment -

        Coincident with this change being made, the message should be very explicit how to enable runtime subclassing if that's what users want.

        Show
        Craig L Russell added a comment - Coincident with this change being made, the message should be very explicit how to enable runtime subclassing if that's what users want.
        Hide
        Michael Vorburger added a comment -

        No reactions to this in months... at least document this, see the OPENJPA-650 ?

        Show
        Michael Vorburger added a comment - No reactions to this in months... at least document this, see the OPENJPA-650 ?

          People

          • Assignee:
            Michael Dick
            Reporter:
            Michael Vorburger
          • Votes:
            1 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development