[OPENJPA-251] org.apache.openjpa.enhance.Reflection.getDeclaredMethod() has undefined behavior, leading to VM-dependent crashes

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.9.7
• Fix Version/s: 1.0.2, 1.1.0
• Component/s: jpa
• Environment: Sun JDK 6.01
• Assignee: Unassigned
• Reporter: Jonathan Feinberg
• Created: 06/Jun/07 16:29
• Updated: 09/Mar/10 18:32
• Resolved: 31/Jan/08 00:02

Description

Given

public interface A

{ Object getId(); }

@Entity
public class B implements A {
@Id
public String getId()

{ return "foo"; }

}

B.class.getDeclaredMethods() will include both "public java.lang.String B.getId()" and "public java.lang.Object B.getId()". The order in which these two methods appear is NOT DEFINED! Because org.apache.openjpa.enhance.Reflection.getDeclaredMethod() returns the first matching method, and because that method might well be the abstract one retuning Object, OpenJPA will complain that it cannot persist an ID with a non-explicit strategy, and throw up.

Class.getDeclaredMethod() (note singular, not plural) is defined to return the method with the most specific return type under these circumstances, and should therefore be used. Here's my implementation of Reflection.getDeclaredMethod:

private static Method getDeclaredMethod(Class cls, String name, Class param)
{
Class[] params = param == null ? new Class[0] : new Class[]

{ param }

;
try

{ return cls.getDeclaredMethod(name, params); }

catch (Exception e)

{ return null; }

}

Issue Links

• is related to: OPENJPA-329 Generic interface may cause the openjpa Reflection code to pickup the wrong getter method