[OPENJPA-2118] Prepared SQL query does not handle collection-valued parameter where collection is empty

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.0.0, 2.1.0, 2.2.0
• Fix Version/s: 2.0.2, 2.1.2, 2.2.1, 2.3.0
• Component/s: sql
• Assignee: Heath Thomann
• Reporter: Heath Thomann
• Created: 30/Jan/12 22:14
• Updated: 31/May/12 01:49
• Resolved: 31/May/12 01:49

Description

In PreparedQueryImpl.setCollectionValuedParameter, we do a '%n' but don't check for n==0, as can be seen here:

private void setCollectionValuedParameter(Map<Integer,Object> result,
Collection values, int[] indices, Object param) {
int n = values.size();
Object[] array = values.toArray();
if (n > indices.length || indices.length%n != 0) { <---------------------line 389 in 2.0.x

When n==0, the following exception will occur:

Exception data: java.lang.ArithmeticException: divide by zero
at org.apache.openjpa.jdbc.kernel.PreparedQueryImpl.setCollectionValuedParameter(PreparedQueryImpl.java:389)

I will upload a test to reproduce this issue and a proposed fix in the next day or two.

Issue Links

• is related to: OPENJPA-1738 Prepared SQL query does not handle collection-valued parameter of persistence-capable objects