[OPENJPA-2101] PersistenceProductDerivation overwrites the RemoteCommitProvider configuration

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.1.1, 2.2.0
• Fix Version/s: 2.2.0
• Component/s: kernel
• Assignee: Unassigned
• Reporter: Pedro Aquilino Sánchez
• Created: 27/Dec/11 15:05
• Updated: 02/Feb/12 17:19
• Resolved: 05/Jan/12 14:33

Description

If you set the property openjpa.RemoteCommitProvider to a value distinct from the default (for example "tcp" or "jms"), this value is overwritted with the default "sjvm".

PersistenceProductDerivation uses a incorrect conditional to check if the value is empty. In this code:

// If the datacache is enabled, make sure we have a RemoteCommitProvider
String dc = oconf.getDataCache();
String rcp = oconf.getRemoteCommitProvider();
// If the datacache is set and is something other than false
if (dc != null && dc.equals("false") == false) {
// If RCP is null or empty, set it to sjvm.
if (rcp == null || (rcp != null && rcp.equals("") == false))

{ oconf.setRemoteCommitProvider("sjvm"); }

}

The last conditional must be

if (rcp == null || (rcp != null && rcp.equals(""))) {