OpenJPA
  1. OpenJPA
  2. OPENJPA-2086

OracleDictionary setFixed and setFormOfUse(NCLOB) are not really doing what they should.

    Details

    • Type: Bug Bug
    • Status: Open
    • Priority: Minor Minor
    • Resolution: Unresolved
    • Affects Version/s: 2.1.1, 2.2.0
    • Fix Version/s: None
    • Component/s: jdbc
    • Environment:
      Oracle 9g, 10g and 11g

      Description

      The setString() method in the OracleDictionary tries to be smart and and look up the column type, and detect and apply nchar and/or fixed char semantics.
      However, I believe that the type information is normally not present for queries, and the functions are never called.

      That means that characters outside the database character set will be lost during translation, and that comparison on CHAR (fixed length) columns will not match if
      the arguments are not padded to the column length.

      I suggest that the special nchar handling is removed as it is not working properly. The only "reliable" option is to set the connection property oracle.jdbc.defaultNChar=true,
      as it would be neigh impossible to get this right in an automatic way.
      (Actually, the sensible option is to convert the database to AL32UTF8, and not use nchars at all since Oracles nchar handling seems to be problematic. )

      Further as the fixedString handling also does not work without type information, the dictionary could either always, or depending on a flag,
      call the setFixedChar() method, or just rely on the connection parameter "fixedString" (and use setObject), avoiding the complexity (and the cost of reflection calls) altogether.

        Activity

        No work has yet been logged on this issue.

          People

          • Assignee:
            Unassigned
            Reporter:
            Karl PIhlblad
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:

              Development