OpenJPA
  1. OpenJPA
  2. OPENJPA-1885

Improve persistAll to avoid redundant checked on each instance

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.0.1
    • Fix Version/s: 2.1.0
    • Component/s: kernel
    • Labels:
      None
    • Patch Info:
      Patch Available

      Description

      Improve persistAll to avoid redundant checked on each instance in the collection.
      When call persistAll() on each object in the collections all the checks and asserts are done.

      1. patch.txt
        7 kB
        Guy Korland

        Issue Links

          Activity

          Guy Korland created issue -
          Guy Korland made changes -
          Field Original Value New Value
          Attachment patch.txt [ 12459537 ]
          Michael Dick committed 1037237 (1 file)
          Reviews: none

          OPENJPA-1885: refactor persistAll in BrokerImpl.
          Submitted By: Guy Korland

          Michael Dick committed 1037827 (1 file)
          Reviews: none

          OPENJPA-1885: rename new method to persistInternal and some code formatting changes

          Hide
          Michael Dick added a comment -

          Thanks for the patch, Guy. The changes have been made in trunk in revision 1037237. I did a little reformatting in rev 1037827 as well.

          Show
          Michael Dick added a comment - Thanks for the patch, Guy. The changes have been made in trunk in revision 1037237. I did a little reformatting in rev 1037827 as well.
          Michael Dick made changes -
          Status Open [ 1 ] Resolved [ 5 ]
          Assignee Michael Dick [ mikedd ]
          Fix Version/s 2.1.0 [ 12314542 ]
          Resolution Fixed [ 1 ]
          Michael Dick made changes -
          Link This issue relates to OPENJPA-1888 [ OPENJPA-1888 ]
          Hide
          Michael Dick added a comment -

          The patch for OPENJPA-1888 contains this fix as well.

          Show
          Michael Dick added a comment - The patch for OPENJPA-1888 contains this fix as well.
          Michael Dick made changes -
          Status Resolved [ 5 ] Closed [ 6 ]

            People

            • Assignee:
              Michael Dick
              Reporter:
              Guy Korland
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development