[OPENJPA-1713] OutOfMemory caused by EntityManagerImpl.push/popFetchPlan processing

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.1.0, 1.2.2, 2.0.0
• Fix Version/s: 2.0.1, 2.1.0
• Component/s: kernel
• Assignee: Albert Lee
• Reporter: Albert Lee
• Created: 30/Jun/10 15:29
• Updated: 09/Aug/10 21:35
• Resolved: 09/Aug/10 21:32

Description

There is a leak in memory in the EntityManagerImpl push/popFetchPlan processing where fetch plan associated with the current fetch configuration is add to the _plans IdentityHashMap but never remove from it.

private Map<FetchConfiguration,FetchPlan> _plans = new IdentityHashMap<FetchConfiguration,FetchPlan>(1);

public FetchPlan getFetchPlan() {
assertNotCloseInvoked();
_broker.lock();
try {
FetchConfiguration fc = _broker.getFetchConfiguration();
FetchPlan fp = _plans.get(fc);
if (fp == null)

{ fp = _emf.toFetchPlan(_broker, fc); _plans.put(fc, fp); <<< added to _plans }

return fp;
} finally

{ _broker.unlock(); }
}

public FetchPlan pushFetchPlan() {
assertNotCloseInvoked();
_broker.lock();
try { _broker.pushFetchConfiguration(); return getFetchPlan(); } finally { _broker.unlock(); }

}

public void popFetchPlan() {
assertNotCloseInvoked();
_broker.lock();
try

{ _broker.popFetchConfiguration(); <<< but never remove when the fetch plan is popped. }

finally

{ _broker.unlock(); }

}

The only time _plans is cleaned up are during clear() or closed().