[OPENJPA-1328] Move cacheable class configuration to ClassMetaData

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.2.0, 1.2.1
• Fix Version/s: 1.0.4, 1.2.2, 1.3.0, 2.0.0-beta
• Component/s: datacache
• Assignee: Michael Dick
• Reporter: Jody Grassel
• Created: 25/Sep/09 18:38
• Updated: 09/Mar/10 18:31
• Resolved: 13/Nov/09 01:37

Description

I'm proposing to move the cacheable class configuration processing from the datacache classes to ClassMetaData. The feature, introduced in OPENJPA-1045, effectively works by returning null for ClassMetaData.getDataCacheName(), where classes which should not be cached return null, otherwise the name of the datacache they may be cached by is returned.

THe problem is that some third party datacache plugins are not reentrant, and the existing ClassMetaData.isCacheable() makes use of the method call getRepository().getConfiguration().getDataCacheManagerInstance(). This invokes the initialization of the datacache, which may result in further initialization/copying of CMD objects, which reenter the isCacheable() method. If a third party datacache plugin is not reentrant safe, this can cause a failure in the form of Exceptions or hung threads.