Uploaded image for project: 'OpenJPA'
  1. OpenJPA
  2. OPENJPA-1116

Annotation Strategy not working

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • 1.3.0, 2.0.0-M2
    • 1.3.0, 2.0.0-M3
    • jdbc
    • None
    • Windows XP, openjpa-2.0.0 source code
    • Patch Available

    Description

      I had 2 entities, Person and Address where person had id, age, name and address_id and person had id and city.
      I tried to apply the Strategy on Address so that upon execution of JPQL query "Select p from Person p" the SQL query fired should make Inner Join rather than the default Left Outer Join.
      I created a Strategy class InnerJoinStrategy that makes sure this happens by overriding the selectEagerJoin() method and gave @Strategy(value = "somepackage.InnerJoinStrategy" ) in Person class before getAddress() method.
      But unexpectedly, it was still making the LeftOuterJoin rather than the desired InnerJoin. Upon debugging I found that my strategy was never being called. I debugged further and found that in AnnotationPersistenceMappingParser class in parseMemberMappingAnnotations() method, for the case STRAT( which belongs to the Strategy annotation) the strategy value was being set in ValueMappingInfo, while from RuntimeStrategyInstaller it was being fetched from FieldMappingInfo. I changed the code to set it in FieldMappingInfo and everything worked fine.

      Attachments

        1. OPENJPA-1116-2.0.0(2).patch
          0.8 kB
          Ashish Paliwal
        2. OPENJPA-1116-2.0.0.patch
          7 kB
          Ashish Paliwal
        3. testStrategyAnnotation.jar
          3 kB
          Ashish Paliwal

        Activity

          People

            ppoddar@apache.org Pinaki Poddar
            ashishpaliwal Ashish Paliwal
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: