Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.0.0-beta
    • Fix Version/s: 2.0.0-beta
    • Component/s: None
    • Labels:
      None

      Description

      Support manual delimiters for the following annotations:
      EntityResult
      FieldResult
      ColumnResult

      Support the automatic delimiting of delimiters

      1. manual_patch.txt
        14 kB
        Dianne Richards
      2. delim_id_xml_patch.txt
        89 kB
        Dianne Richards
      3. delim_id_fix.txt
        0.8 kB
        Dianne Richards
      4. delim_id_fix_testcase.txt
        133 kB
        Dianne Richards
      5. delim_doc_patch.txt
        9 kB
        Dianne Richards
      6. auto_delim_id_patch.txt
        99 kB
        Dianne Richards

        Activity

        Hide
        Jeremy Bauer added a comment -

        Committed patch delim_doc_patch.txt dated 2010-01-18 03:25 PM under revision 900446 for Dianne.

        Show
        Jeremy Bauer added a comment - Committed patch delim_doc_patch.txt dated 2010-01-18 03:25 PM under revision 900446 for Dianne.
        Hide
        Dianne Richards added a comment -

        Attaching patch for documentation changes for delimited ids.

        Show
        Dianne Richards added a comment - Attaching patch for documentation changes for delimited ids.
        Hide
        Dianne Richards added a comment -

        Attaching a testcase for the previoiusly attached fix.

        Show
        Dianne Richards added a comment - Attaching a testcase for the previoiusly attached fix.
        Hide
        Dianne Richards added a comment -

        Attaching a fix for a problem that occurred when a connection username was specified. In this case, the username acts as a default schema. This created another scenario where we were trying to compare a column name retrieved from the database (which is always undelimited) with an annotation delimited name. THis fix handles that scenario.

        Show
        Dianne Richards added a comment - Attaching a fix for a problem that occurred when a connection username was specified. In this case, the username acts as a default schema. This created another scenario where we were trying to compare a column name retrieved from the database (which is always undelimited) with an annotation delimited name. THis fix handles that scenario.
        Hide
        Dianne Richards added a comment -

        Providing patch for implementing and testing delimited ids being specified in mapping files.

        Show
        Dianne Richards added a comment - Providing patch for implementing and testing delimited ids being specified in mapping files.
        Hide
        Jeremy Bauer added a comment -

        Committed auto_delim_id_patch.txt for Dianne (with a few minor updates) under revision 827727. The use of separate maps into the schema for comparison purposes is a bit quirky and will likely prove to be problematic. As Dianne indicated in several TODO comments, A more global and solid delimiting approach design needs to be provided in the near future.

        Show
        Jeremy Bauer added a comment - Committed auto_delim_id_patch.txt for Dianne (with a few minor updates) under revision 827727. The use of separate maps into the schema for comparison purposes is a bit quirky and will likely prove to be problematic. As Dianne indicated in several TODO comments, A more global and solid delimiting approach design needs to be provided in the near future.
        Hide
        Dianne Richards added a comment -

        This patch contains the support for auto delimiting identifiers - delimiting based on the <delimited-identifiers> element being specified in the mapping file.

        Some exceptions:

        1. The catalog elements are not delimited yet since catalog is not currently supported by openjpa.

        2. The columnDefinition elements are not delimited yet since there is some complication involved. If a VARCHAR or other pre-defined column definition is delimited, the database rejects it. Presumably, delimiting will only work for user defined column definitions. This will take some time to work out and test.

        3. There is some temporary code to work around a problem that occurs when a column name or schema name or sequence name is read from the database to compare with the current request. If they had been originally delimited, this is not known. The temporary solution works, but is limited and not good. A new scheme will be implemented at a later time (hopefully soon).

        Show
        Dianne Richards added a comment - This patch contains the support for auto delimiting identifiers - delimiting based on the <delimited-identifiers> element being specified in the mapping file. Some exceptions: 1. The catalog elements are not delimited yet since catalog is not currently supported by openjpa. 2. The columnDefinition elements are not delimited yet since there is some complication involved. If a VARCHAR or other pre-defined column definition is delimited, the database rejects it. Presumably, delimiting will only work for user defined column definitions. This will take some time to work out and test. 3. There is some temporary code to work around a problem that occurs when a column name or schema name or sequence name is read from the database to compare with the current request. If they had been originally delimited, this is not known. The temporary solution works, but is limited and not good. A new scheme will be implemented at a later time (hopefully soon).
        Hide
        Dianne Richards added a comment -

        Pinaki - The delimited-identifiers tag is part of the support for auto-delimiting. It wasn't needed for the manual delimiting that I supported in the first phase.

        Show
        Dianne Richards added a comment - Pinaki - The delimited-identifiers tag is part of the support for auto-delimiting. It wasn't needed for the manual delimiting that I supported in the first phase.
        Hide
        Pinaki Poddar added a comment -

        I do not see any mention/processing of delimited-identifiers tag in XML descriptor processing stage. But this 'global' flag determines how the identifiers will be processed for delimiters, as I remember from Expert Group discussion.
        So the basic question is: how is the global flag being taken into account?

        Show
        Pinaki Poddar added a comment - I do not see any mention/processing of delimited-identifiers tag in XML descriptor processing stage. But this 'global' flag determines how the identifiers will be processed for delimiters, as I remember from Expert Group discussion. So the basic question is: how is the global flag being taken into account?
        Hide
        Jeremy Bauer added a comment -

        Committed manual_patch.txt for Dianne under revision 803612.

        Show
        Jeremy Bauer added a comment - Committed manual_patch.txt for Dianne under revision 803612.
        Hide
        Dianne Richards added a comment -

        Attaching patch for the rest of the manual delimited id support.

        Show
        Dianne Richards added a comment - Attaching patch for the rest of the manual delimited id support.

          People

          • Assignee:
            Dianne Richards
            Reporter:
            Dianne Richards
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development