OpenEJB
  1. OpenEJB
  2. OPENEJB-956

Installation of Java Agent fails when used with Tomcat and CATALINA_HOME != CATALINA_BASE

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 3.1
    • Fix Version/s: 3.1.1
    • Component/s: tomee
    • Labels:
      None
    • Environment:
      All

      Description

      The war installer for using openejb in Tomcat installs the java agent into CATALINA_HOME/lib.
      Then it patches catalina.sh and catalina.bat to add a -javaagent parameter during startup. That code erroneously assumes the agent was installed into CATALINA_BASE (instead of CATALINA_HOME). If both are the same that's fine, if not, it breaks.

      I attach the simple patch.

      Note: Installing into CATALINA_BASE might actually be nicer, but CATALINA_BASE/lib is not on the default search path of the Tomcat loaders, so one would also have to patch common.loader in CATALINA_BASE/conf/catalina.properties.

      1. openejb.patch
        2 kB
        Rainer Jung

        Activity

        Hide
        Rainer Jung added a comment -

        Patch

        Show
        Rainer Jung added a comment - Patch
        Hide
        Jonathan Gallimore added a comment -

        Many thanks for the patch, I've committed it (r719114).

        Show
        Jonathan Gallimore added a comment - Many thanks for the patch, I've committed it (r719114).
        Hide
        Jonathan Gallimore added a comment -

        Committed in r719114

        Show
        Jonathan Gallimore added a comment - Committed in r719114

          People

          • Assignee:
            Jonathan Gallimore
            Reporter:
            Rainer Jung
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development