OpenEJB
  1. OpenEJB
  2. OPENEJB-453 Validation for EJB 3.0 beans
  3. OPENEJB-847

Validation: @Resource UserTransaction injection mistakenly used on bean with Container-Managed Transactions

    Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.1.3
    • Component/s: None
    • Labels:
      None

      Activity

      David Blevins made changes -
      Status Resolved [ 5 ] Closed [ 6 ]
      Hide
      David Blevins added a comment -

      $ svn ci container
      Sending container/openejb-core/src/main/java/org/apache/openejb/config/rules/CheckUserTransactionRefs.java
      Sending container/openejb-core/src/main/resources/org/apache/openejb/config/rules/Messages.properties
      Sending container/openejb-core/src/test/java/org/apache/openejb/config/rules/CheckUserTransactionRefsTest.java
      Transmitting file data ...
      Committed revision 904482.

      Show
      David Blevins added a comment - $ svn ci container Sending container/openejb-core/src/main/java/org/apache/openejb/config/rules/CheckUserTransactionRefs.java Sending container/openejb-core/src/main/resources/org/apache/openejb/config/rules/Messages.properties Sending container/openejb-core/src/test/java/org/apache/openejb/config/rules/CheckUserTransactionRefsTest.java Transmitting file data ... Committed revision 904482.
      David Blevins made changes -
      Fix Version/s 3.1.3 [ 12314215 ]
      Fix Version/s 3.1.1 [ 12313484 ]
      Hide
      David Blevins added a comment -

      Sorry, I glanced at it and it looked good. User on IRC ran into this the other day and didn't get the validation message. Small bug, we were checking the bean.getResourceRef() instead of the bean.getResourceEnvRef() list.

      I redid the test case so that it just checks an annotated bean rather than constructing that part of the jaxb tree by hand. Will reopen and close the jira.

      Show
      David Blevins added a comment - Sorry, I glanced at it and it looked good. User on IRC ran into this the other day and didn't get the validation message. Small bug, we were checking the bean.getResourceRef() instead of the bean.getResourceEnvRef() list. I redid the test case so that it just checks an annotated bean rather than constructing that part of the jaxb tree by hand. Will reopen and close the jira.
      Jacek Laskowski made changes -
      Resolution Fixed [ 1 ]
      Fix Version/s 3.1.1 [ 12313484 ]
      Status In Progress [ 3 ] Resolved [ 5 ]
      Hide
      Jacek Laskowski added a comment -

      Awaiting comments (so I can close it without wondering about some potential improvements )

      Show
      Jacek Laskowski added a comment - Awaiting comments (so I can close it without wondering about some potential improvements )
      Jacek Laskowski made changes -
      Status Open [ 1 ] In Progress [ 3 ]
      Jacek Laskowski made changes -
      Assignee Jacek Laskowski [ jlaskowski ]
      David Blevins made changes -
      Field Original Value New Value
      Summary @Resource UserTransaction injection on bean with Container-Managed Transactions Validation: @Resource UserTransaction injection mistakenly used on bean with Container-Managed Transactions
      David Blevins created issue -

        People

        • Assignee:
          Jacek Laskowski
          Reporter:
          David Blevins
        • Votes:
          0 Vote for this issue
          Watchers:
          0 Start watching this issue

          Dates

          • Created:
            Updated:
            Resolved:

            Development